Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-135 - ANOSPP - Sample Manifest for creation of Stock plate #4155

Closed
4 tasks done
andrewsparkes opened this issue Jun 14, 2024 · 3 comments · Fixed by #4154
Closed
4 tasks done

Y24-135 - ANOSPP - Sample Manifest for creation of Stock plate #4155

andrewsparkes opened this issue Jun 14, 2024 · 3 comments · Fixed by #4154
Assignees
Labels
ANOSPP Size: M Medium - medium effort & risk

Comments

@andrewsparkes
Copy link
Member

andrewsparkes commented Jun 14, 2024

User story
As R&D and SSRs we would like a sample manifest to create the stock plates for the ANOSPP pipeline.

Who are the primary contacts for this story
Scott T
Andrew S

Who is the nominated tester for UAT
Scott T

Acceptance criteria
To be considered successful the solution must allow:

  • a sample manifest for ANOSPP can be downloaded
  • the completed sample manifest can be uploaded and is validated
  • Partner ID is stored in supplier sample name, and Specimen Plate Barcode in sample description (NB. no need for special control types as no controls for ANOSPP)
  • Plate purpose to be created is ANOSPP specific, called LANS-96 Stock (TBC)

Dependencies
This story is blocked by the following dependencies:
None

References
This story has a non-blocking relationship with:
ANOSPP pipeline config

Additional context
This is similar to the Bioscan manifest but less complex (no controls so no special connection with supplier sample name field required).

See Scott Ts document on ANOSPP here

@psd-issuer psd-issuer bot changed the title ANOSPP - Sample Manifest for creation of Stock plate Y24-135 - ANOSPP - Sample Manifest for creation of Stock plate Jun 14, 2024
@andrewsparkes andrewsparkes added the Size: M Medium - medium effort & risk label Jun 14, 2024
@KatyTaylor
Copy link
Contributor

Can we confirm what columns are needed at this point? Exactly the same as Bioscan, but minus the 'bioscan_control_type' field?

@andrewsparkes andrewsparkes self-assigned this Jun 26, 2024
@andrewsparkes
Copy link
Member Author

andrewsparkes commented Jun 26, 2024

@ScottThurston I'm going to assume same columns as for Bioscan minus the bioscan special control types (will use the standard control type column in case you want to include controls).

The only special columns here are the supplier sample name where we want them to put the Partner ID, and the sample description in which we want them to put the specimen plate barcode (same as bioscan).
Please let me know if it should include any other information (columns).

columns:
- :sanger_plate_id
- :well
- :sanger_sample_id
- :supplier_name
- :retention_instruction
- :cohort
- :country_of_origin
- :date_of_sample_collection
- :sample_taxon_id
- :sample_common_name
- :sample_description_specimen_plate_barcode
- :sample_type
- :donor_id
- :control_type

@ScottThurston
Copy link

Sounds good,
I don't believe there are any GBS-specific columns that are required to be added to the manifest.

@andrewsparkes andrewsparkes transferred this issue from sanger/limber Jun 26, 2024
@psd-issuer psd-issuer bot changed the title Y24-135 - ANOSPP - Sample Manifest for creation of Stock plate Y24-167 - Y24-135 - ANOSPP - Sample Manifest for creation of Stock plate Jun 26, 2024
@andrewsparkes andrewsparkes linked a pull request Jun 26, 2024 that will close this issue
@andrewsparkes andrewsparkes changed the title Y24-167 - Y24-135 - ANOSPP - Sample Manifest for creation of Stock plate Y24-135 - ANOSPP - Sample Manifest for creation of Stock plate Jun 27, 2024
@KatyTaylor KatyTaylor added the On Hold On hold label Jul 2, 2024
@andrewsparkes andrewsparkes removed the On Hold On hold label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ANOSPP Size: M Medium - medium effort & risk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants