Allow to rename, describe and set default arguments using DeriveObjectSettings.
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlegIlyenko
approved these changes
Feb 18, 2018
build.sbt
Outdated
| @@ -1,6 +1,6 @@ | |||
| name := "sangria" | |||
| organization := "org.sangria-graphql" | |||
| version := "1.3.3" | |||
| version := "1.3.4-SNAPSHOT" | |||
| getArgument(pos, methodName, argName).right.map{ | ||
| case arg if argType <:< arg.typeSignature.resultType ⇒ Nil | ||
| case arg ⇒ List( | ||
| pos → s"Wrong type of default value '$default' for argument '$argName' of method '$methodName': expected '${arg.typeSignature.resultType}', but got '$argType'." |
There was a problem hiding this comment.
I think we would need to rely on the standard set of validations for a default value type. It is based on ArgumentType, ToInput type-classes as well as some run-time validations. It still will provide the same compile-time guarantees. It's a minor thing, I will adjust it after the merge.
|
Thank you for accepting my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#318: Added the following
DeriveObjectSettings:MethodArgumentRenameMethodArgumentDescriptionMethodArgumentsDescriptionMethodArgumentDefaultMethodArgument