Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass parameter.fields When parameter is being Passed in #21

Merged
merged 10 commits into from
Dec 21, 2021
Merged

Pass parameter.fields When parameter is being Passed in #21

merged 10 commits into from
Dec 21, 2021

Conversation

ChihweiLHBird
Copy link
Member

Related issue: #18

@ChihweiLHBird ChihweiLHBird requested a review from a team December 16, 2021 01:40
@ChihweiLHBird
Copy link
Member Author

Hi @ahopkins, I tried to make the test cases, but it seems the openapi specification by docstring won't be included in the response of the test client, whereas it does appear in the same URL with a real client and server. Need deeper investigation here, may I have some suggestions? Like where the docstring openapi specification is being processed?

@ChihweiLHBird
Copy link
Member Author

ChihweiLHBird commented Dec 16, 2021 •
edited
Loading

Hi @ahopkins, I tried to make the test cases, but it seems the openapi specification by docstring won't be included in the response of the test client, whereas it does appear in the same URL with a real client and server. Need deeper investigation here, may I have some suggestions? Like where the docstring openapi specification is being processed?

Never mind, I have fixed it. It was caused by incorrect format of the openapi docstring done by my text editor.

@ahopkins
Copy link
Member

Like where the docstring openapi specification is being processed?

https://github.com/sanic-org/sanic-ext/blob/main/sanic_ext/extensions/openapi/blueprint.py#L104

@ChihweiLHBird
Copy link
Member Author

Like where the docstring openapi specification is being processed?

https://github.com/sanic-org/sanic-ext/blob/main/sanic_ext/extensions/openapi/blueprint.py#L104

Thanks!

@ChihweiLHBird
Copy link
Member Author

I think it is ready to be reviewed. @sanic-org/extension

@ahopkins ahopkins mentioned this pull request Dec 16, 2021
Closed
@ahopkins ahopkins merged commit 3ed0eef into sanic-org:main Dec 21, 2021
@ChihweiLHBird ChihweiLHBird deleted the zhiwei/param branch December 21, 2021 07:32
@ChihweiLHBird ChihweiLHBird mentioned this pull request Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahopkins ahopkins ahopkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChihweiLHBird @ahopkins