Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swagger UI Version; Adding Type Annotations #76

Merged
merged 5 commits into from
Jun 28, 2022

Conversation

ChihweiLHBird
Copy link
Member

@ChihweiLHBird ChihweiLHBird commented May 3, 2022

  1. Protocol type (https) added to CDN URLs, to ensure security transportation and to resolve the warnings by IDE (VS Code).
  2. Pump up Swagger UI Version from 4.1.0 to 4.10.3.
    4.10.3 is currently the most popular version of Swagger UI and it resolved a security issue compared with 4.1.0
    (The security issue was resolved in all versions >= 4.1.3, details: https://security.snyk.io/vuln/SNYK-JS-SWAGGERUI-2314885)
    Unit testing passed but it probably needs more manual (eye) testing due to the natures of UI stuff, will be done in days.
  3. Added some type annotations to make the dev experience with IDEs better.

@ChihweiLHBird ChihweiLHBird requested a review from a team May 3, 2022 04:23
@ahopkins ahopkins merged commit bea9594 into sanic-org:main Jun 28, 2022
@ChihweiLHBird ChihweiLHBird deleted the zhiwei/minor-stuff branch June 28, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants