Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed field 'type': 'object' from swagger json when using doc.Object() #149

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

AHBaber
Copy link
Contributor

@AHBaber AHBaber commented Dec 11, 2019

This is a new pull request based around the same issue as in pull/145

This version has two differences:

  1. it implements the smaller change has discussed in the original request
  2. the master branch was updated to contain the commits made after the original pull request was initially made.

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files           5        5           
  Lines         461      461           
  Branches       94       94           
=======================================
  Hits          439      439           
  Misses          7        7           
  Partials       15       15
Impacted Files Coverage Δ
sanic_openapi/doc.py 99.08% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdf880...eb62442. Read the comment docs.

Copy link
Member

@chenjr0719 chenjr0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenjr0719 chenjr0719 merged commit 60605ce into sanic-org:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants