New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc.py add operation #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@ahopkins I think this PR can be merged. |
@pytomtoto Looks like there is some tests that keep failing CI. Can you please look into correcting them? |
done.@ahopkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 95.38% 95.43% +0.05%
==========================================
Files 4 4
Lines 433 438 +5
Branches 93 93
==========================================
+ Hits 413 418 +5
Misses 6 6
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @pytomtoto
Would you please add some test for your contribution?
Here is a similar test:
https://github.com/huge-success/sanic-openapi/blob/c79a0b34535d2039d6901d166c39583017f67d17/tests/test_decorators.py#L37-L49
done @chenjr0719 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
fix swagger page