Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc.py add operation #95

Merged
merged 11 commits into from Jul 1, 2019
Merged

doc.py add operation #95

merged 11 commits into from Jul 1, 2019

Conversation

pytomtoto
Copy link
Contributor

fix swagger page

chenjr0719
chenjr0719 previously approved these changes May 6, 2019
Copy link
Member

@chenjr0719 chenjr0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chenjr0719
Copy link
Member

@ahopkins I think this PR can be merged.

hampsterx
hampsterx previously approved these changes May 17, 2019
@ahopkins
Copy link
Member

@pytomtoto Looks like there is some tests that keep failing CI. Can you please look into correcting them?

@pytomtoto pytomtoto dismissed stale reviews from hampsterx and chenjr0719 via 03e8b4f June 30, 2019 12:32
@pytomtoto
Copy link
Contributor Author

pytomtoto commented Jun 30, 2019

@pytomtoto Looks like there is some tests that keep failing CI. Can you please look into correcting them?

done.@ahopkins

Copy link
Contributor Author

@pytomtoto pytomtoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #95 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   95.38%   95.43%   +0.05%     
==========================================
  Files           4        4              
  Lines         433      438       +5     
  Branches       93       93              
==========================================
+ Hits          413      418       +5     
  Misses          6        6              
  Partials       14       14
Impacted Files Coverage Δ
sanic_openapi/doc.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79a0b3...e7e7b3b. Read the comment docs.

Copy link
Member

@chenjr0719 chenjr0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pytomtoto
Copy link
Contributor Author

Hi, @pytomtoto

Would you please add some test for your contribution?
Here is a similar test:
https://github.com/huge-success/sanic-openapi/blob/c79a0b34535d2039d6901d166c39583017f67d17/tests/test_decorators.py#L37-L49

done @chenjr0719

Copy link
Member

@chenjr0719 chenjr0719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@chenjr0719 chenjr0719 merged commit d03fd00 into sanic-org:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants