-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed path_to_parts splitter #40
Conversation
That is a slick solution. Will take a closer look and then also run it against the main repo. I keep meaning to add an action for that here. |
Might need some work on this to get all the tests passing. At least these tests on the main repo are failing:
I think the signals should be an easy fix by changing the delimiter from |
I was a bit confused about where those tests are. |
Great, thanks. Can you add a test in here as well with some unicode tests? The Sanic core tests use: |
Done! |
All good 🎉 |
a8bcdc9
to
fb8122b
Compare
This pull request fixes the
path_to_parts
helper method for such routeThe idea for this solution was taken from the stackoverflow :)