Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always return request object #10

Closed
ahopkins opened this issue Jan 28, 2021 · 0 comments · Fixed by #12
Closed

Always return request object #10

ahopkins opened this issue Jan 28, 2021 · 0 comments · Fixed by #12

Comments

@ahopkins
Copy link
Member

As discussed in #6, we should always return a Request object.

Tuple[Optional[Request], HTTPResponse]
ashleysommer added a commit to ashleysommer/sanic-testing that referenced this issue Jan 28, 2021
@ashleysommer
Fix sanic-org#10, always return a tuple from SanicTestClient request,…
a414d4c 
… and ASGITestClient `request()`
@ashleysommer ashleysommer mentioned this issue Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return tuples ashleysommer/sanic-testing
1 participant
@ahopkins