Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow HTTPX 0.23 #39

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Allow HTTPX 0.23 #39

merged 2 commits into from
Jun 28, 2022

Conversation

ctrlaltf24
Copy link
Contributor

Fixes: #38

@novotl novotl mentioned this pull request May 24, 2022
Closed
@ctrlaltf24
Copy link
Contributor Author

@ahopkins do you have a second to review so this repo's no longer vulnerable to GHSA-h8pj-cxx2-jfg2 ?

@amn41
Copy link

amn41 commented Jun 28, 2022 •
edited by ahopkins
Loading

just commenting to mention that sanic is a dependency of rasa and it would be a big help for us if this vulnerability were resolved.

@ahopkins
Copy link
Member

ahopkins commented Jun 28, 2022 •
edited
Loading

Will be released in the coming day or two with the upcoming release.

@ahopkins ahopkins merged commit c04fa9a into sanic-org:main Jun 28, 2022
@ctrlaltf24 ctrlaltf24 deleted the httpx-0.23 branch June 28, 2022 16:33
@ancalita
Copy link

@ahopkins would this dependency be updated in sanic versions 20.12 LTS & 21.12 LTS as well? Do you have a timeline please?

@ahopkins
Copy link
Member

LTS versions will be released tonight or tomorrow with v22.6.

@ahopkins
Copy link
Member

@ancalita Trying to make the change to v20.12 is going to be a PITA because there have been a number of breaking changes in the httpx API since then. This was one of the motivating factors for moving sanic.testing to sanic-testing.

@ahopkins
Copy link
Member

v0.8.3 is released now and can be used with 21.12LTS. Starting after v22.3 the versioning should track easier.

ChihweiLHBird pushed a commit to ChihweiLHBird/sanic-testing that referenced this pull request Aug 8, 2022
@ctrlaltf24 @ahopkins @ChihweiLHBird
Allow HTTPX 0.23 (sanic-org#39)
8e6308a 
Co-authored-by: Adam Hopkins <adam@amhopkins.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahopkins ahopkins ahopkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow httpx 0.23.0
4 participants
@ctrlaltf24 @amn41 @ahopkins @ancalita