Pickle fixes, and other changes #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… weird App pickling error seen when using TestManager (specifically on the ASGITestClient) Add logic to remove the CookieJar from ASGITestClient before pickling, then add it back when unpickled. The cookie jar contains a ThreadLock which cannot be pickled. Fixes sanic-org#3 Improve gather_request logic in TestClient and ASGITestClient, Fixes sanic-org#4 Change "before_server_end" to "before_server_stop". Fixes sanic-org#5 Fix return type on _sanic_endpoint_test, Fixes sanic-org#6 Fixes sanic-org#6
|
I pulled the branch and had some failing tests. I will try and get CI setup today. See #8. Also, I ran |
|
Yeah, this won't work against sanic master until after sanic/#2009 is merged. Try it again now that's it's merged? |
|
I thought I had. I went too fast and didn't realize that my Sanic master with this branch. |
|
And this project's tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about bundling these all up, while fixing #3 I found some issues and fixed them all in one go.
Move nested subfuctions out of TestClient class methods. This fixes a weird App pickling error seen when using TestManager (specifically on the ASGITestClient)
Add logic to remove the CookieJar from ASGITestClient before pickling, then add it back when unpickled. The cookie jar contains a ThreadLock which cannot be pickled.
Fixes Adding _test_manager object to Sanic App prevents App from being pickled #3
Improve gather_request logic in TestClient and ASGITestClient, Fixes Potentially incorrect gather_request logic in TestClient #4
Change "before_server_end" to "before_server_stop". Fixes Typo: Listener on "before_server_end" should be "before_server_stop" #5
Fix return type on _sanic_endpoint_test, Fixes Incorrect Return type on _sanic_endpoint_test #6
Re-Blacked all python files