Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code is indented with tabs instead of spaces #1

Closed
seemethere opened this issue Oct 14, 2016 · 3 comments
Closed

Code is indented with tabs instead of spaces #1

seemethere opened this issue Oct 14, 2016 · 3 comments

Comments

@seemethere
Copy link
Member

Just wanted to comment on this because I wanted to contribute some documentation for sanic, but I just wanted to let you know all of your indentation right now is being done with tabs.

Instead of submitting a pull request for this though, and overwriting all the hard work you did to get this up and running, I thought I would submit an issue to allow you to fix it yourself.

It's as easy as running :retab in vim or if you are using pycharm it's as easy as reformatting.

Or you could use something like sed.

I can still take care of it if you want just let me know.

@n1ywb
Copy link
Contributor

n1ywb commented Oct 15, 2016

it would be nice to fix, pycharm is showing pep8 violations on every line due to this

@channelcat
Copy link
Contributor

Ah, I did not know this would cause issues. I've run a reformat in pycharm and merged it in :). Let me know if anything still looks funky.

#5

@seemethere
Copy link
Member Author

awesome! Will do! Thanks for being quick @channelcat

seemethere pushed a commit that referenced this issue Nov 21, 2016
seemethere pushed a commit that referenced this issue Feb 14, 2017
Merge commits with master
zenixls2 pushed a commit to zenixls2/sanic that referenced this issue Apr 11, 2017
r0fls pushed a commit that referenced this issue Apr 17, 2017
seemethere pushed a commit that referenced this issue Jun 10, 2017
r0fls pushed a commit that referenced this issue Jan 8, 2018
r0fls pushed a commit that referenced this issue Jan 16, 2018
use single quote in readme.rst
seemethere pushed a commit that referenced this issue Oct 3, 2018
yunstanford pushed a commit that referenced this issue Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants