Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket binding implemented properly for IPv6 and UNIX sockets. #1641

Merged
merged 36 commits into from Jun 29, 2020
Merged

Socket binding implemented properly for IPv6 and UNIX sockets. #1641

merged 36 commits into from Jun 29, 2020

Commits on Jul 23, 2019

  1. Socket binding implemented properly for IPv6 and UNIX sockets. 

    - app.run("::1") for IPv6
- app.run("unix:/tmp/server.sock") for UNIX sockets
- app.run("localhost") retains old functionality (randomly either IPv4 or IPv6)

Do note that IPv6 and UNIX sockets are not fully supported by other Sanic facilities.
In particular, request.server_name and request.server_port are currently unreliable.
    @Tronic
    Tronic committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    5431afd View commit details
    Browse the repository at this point in the history

  2. Fix Windows compatibility by not referring to socket.AF_UNIX unless n… 

    …eeded.
    @Tronic
    Tronic committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    e2efd46 View commit details
    Browse the repository at this point in the history

  3. Compatibility fix.

    @Tronic
    Tronic committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    a58d64e View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2019

  1. Fix test of existing unix socket.

    @Tronic
    Tronic committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    8f57610 View commit details
    Browse the repository at this point in the history

  2. Cleaner unix socket removal.

    @Tronic
    Tronic committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    52451ad View commit details
    Browse the repository at this point in the history

  3. Remove unix socket on exit also with workers=1.

    @Tronic
    Tronic committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    7cb05d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. More pedantic UNIX socket implementation.

    @Tronic
    Tronic committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    67bdf4c View commit details
    Browse the repository at this point in the history

  2. Refactor app to take unix= argument instead of unix:-prefixed host. G… 

    …oin' fast @ unix-socket fixed.
    @Tronic
    Tronic committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    b45f879 View commit details
    Browse the repository at this point in the history

  3. Linter

    @Tronic
    Tronic committed Aug 28, 2019
    Configuration menu
    Copy the full SHA
    c7c1a74 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2019

  1. Merge remote-tracking branch 'upstream/master' into bind_unix_and_ipv6

    @Tronic
    Tronic committed Sep 2, 2019
    Configuration menu
    Copy the full SHA
    ff78e47 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Proxy properties cleanup. Slight changes of semantics. SERVER_NAME no… 

    …w overrides everything.
    @Tronic
    Tronic committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    dcffda2 View commit details
    Browse the repository at this point in the history

  2. Have server fill in connection info instead of request asking the soc… 

    …ket.

- Would be a good idea to remove request.transport entirely but I didn't dare to touch it yet.
    @Tronic
    Tronic committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    e21e2ae View commit details
    Browse the repository at this point in the history

  3. Linter 💣🌟✊💀

    @Tronic
    Tronic committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    69ddbca View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2019

  1. Merge remote-tracking branch 'upstream/master' into bind_unix_and_ipv6

    @Tronic
    Tronic committed Dec 15, 2019
    Configuration menu
    Copy the full SHA
    8214bcb View commit details
    Browse the repository at this point in the history

  2. Fix typing issues. request.server_name returns empty string if host h… 

    …eader is missing.
    @Tronic
    Tronic committed Dec 15, 2019
    Configuration menu
    Copy the full SHA
    e039fef View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @Tronic
    Tronic committed Dec 15, 2019
    Configuration menu
    Copy the full SHA
    0730c7e View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2020

  1. Merge branch 'master' into bind_unix_and_ipv6

    @Tronic
    Tronic committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    055ad6b View commit details
    Browse the repository at this point in the history

  2. Tests were failing, fix connection info.

    @Tronic
    Tronic committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    27301b8 View commit details
    Browse the repository at this point in the history

  3. Linter nazi says you need that empty line.

    @Tronic
    Tronic committed Jan 15, 2020
    Configuration menu
    Copy the full SHA
    1bacaa2 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Rename a to addr, leave client empty for unix sockets.

    @Tronic
    Tronic committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    c0e0999 View commit details
    Browse the repository at this point in the history

  2. Add --unix support when sanic is run as module.

    @Tronic
    Tronic committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    ecd16e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2020

  1. Remove remove_route, deprecated in 19.6.

    @Tronic
    Tronic committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    bafa658 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bind_unix_and_ipv6

    @Tronic
    Tronic committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    7c3d9fb View commit details
    Browse the repository at this point in the history

  3. Improved unix socket binding.

    @Tronic
    Tronic committed Mar 26, 2020
    Configuration menu
    Copy the full SHA
    c776101 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. More robust creating and unlinking of sockets. Show proper and not te… 

    …mporary name in conn_info.
    @Tronic
    Tronic committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d610260 View commit details
    Browse the repository at this point in the history

  2. Add comprehensive tests for unix socket mode.

    @Tronic
    Tronic committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    0422b10 View commit details
    Browse the repository at this point in the history

  3. Hide some imports inside functions to avoid Windows failure.

    @Tronic
    Tronic committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    39b9263 View commit details
    Browse the repository at this point in the history

  4. Mention unix socket mode in deployment docs.

    @Tronic
    Tronic committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    7327b8c View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Merge branch 'master' into bind_unix_and_ipv6

    @Tronic
    Tronic committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    026ee97 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2020

  1. Merge branch 'master' into bind_unix_and_ipv6

    @Tronic
    Tronic committed Apr 9, 2020
    Configuration menu
    Copy the full SHA
    93f8ed3 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Merge branch 'master' into bind_unix_and_ipv6

    @Tronic
    Tronic committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    34e8084 View commit details
    Browse the repository at this point in the history

  2. Fix merge commit.

    @Tronic
    Tronic committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    8a8f0b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2020

  1. Merge branch 'master' into bind_unix_and_ipv6

    @ahopkins
    ahopkins committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    5f18c79 View commit details
    Browse the repository at this point in the history

  2. Make test_unix_connection_multiple_workers pickleable for spawn mode … 

    …multiprocessing.
    @Tronic
    Tronic committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    7ba0a5f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into bind_unix_and_ipv6

    @ahopkins
    ahopkins committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    efa0c6b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into bind_unix_and_ipv6

    @ahopkins
    ahopkins committed Jun 28, 2020
    Configuration menu
    Copy the full SHA
    19898d0 View commit details
    Browse the repository at this point in the history