Added new client_ip accessor

[sjsadowski]

Added new client_ip accessor for ConnInfo class, updated request to use client_ip instead of client to be more representative of what will be returned (actual ipv6 ip instead of bracket wrapped ip)

[sjsadowski]

This will close #1901 when merged

[codecov]

Codecov Report

Merging #2114 (d874ecc) into main (1a352dd) will increase coverage by 0.018%.
The diff coverage is 81.633%.

❗ Current head d874ecc differs from pull request most recent head cab88ba. Consider uploading reports for the commit cab88ba to get more accurate results

@@              Coverage Diff              @@
##              main     #2114       +/-   ##
=============================================
+ Coverage   92.133%   92.151%   +0.018%     
=============================================
  Files           38        38               
  Lines         3470      3478        +8     
  Branches       572       575        +3     
=============================================
+ Hits          3197      3205        +8     
  Misses         185       185               
  Partials        88        88               

Impacted Files	Coverage Δ
sanic/__main__.py	75.000% <33.333%> (ø)
sanic/server.py	88.235% <45.455%> (+0.060%)	⬆️
sanic/http.py	77.491% <75.000%> (ø)
sanic/app.py	92.623% <100.000%> (ø)
sanic/config.py	100.000% <100.000%> (ø)
sanic/errorpages.py	98.519% <100.000%> (ø)
sanic/handlers.py	95.455% <100.000%> (ø)
sanic/headers.py	100.000% <100.000%> (ø)
sanic/mixins/routes.py	93.401% <100.000%> (ø)
sanic/request.py	97.712% <100.000%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aff6604...cab88ba. Read the comment docs.

[ahopkins]

Nice. Some tests when you have a chance? 😎

[sjsadowski]

@ahopkins that's why it's still a draft, need to make sure test_client will do what I want.

[ahopkins]

😆 totally didn't see that. sorry. I was on my phone.

Might need to mock it. IIRC, I had some problems in the past. But, that might have been ASGI client.

[Tronic]

LGTM. Leaving discussion of other necessary work on bracket handling and client IPs elsewhere (I don't believe that socket level client IP is very useful; usually you want true remote IP instead).

[sjsadowski]

Test client doesn't support ipv6, looks like. Going to have to come at the tests from a different direction... probably mocking like @ahopkins suggested.

[ahopkins]

Test client doesn't support ipv6, looks like. Going to have to come at the tests from a different direction... probably mocking like @ahopkins suggested.

I'll spend some time looking at the test client tonight. It should be able to.