Fixed task is created again when adding the task #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaidBySolo
changed the title
SaidBySolo
changed the title
|
@SaidBySolo I changed the base of this to target another PR that is going into the LTS. Can you resolve that conflict? |
Sure :D |
|
@ahopkins Done! |
|
Thank you! 🎊 |
|
Okay... so I think we have some commits in here that we do NOT want to include. This is probably because you (reasonably) branched off
We do not want these commits yet. |
|
Awesome! Thanks |
ahopkins
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, even if a task or a future was received, the task was created and registered once again.
When a user gives a task or future, only the task is added without creating a task or future again.