Document middleware on_request and on_response
#2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without docstrings these methods do not show up in the autogenerated documentation.
Codecov Report
@@ Coverage Diff @@
## main #2398 +/- ##
=============================================
- Coverage 87.167% 87.107% -0.060%
=============================================
Files 60 60
Lines 5003 5003
Branches 905 905
=============================================
- Hits 4361 4358 -3
- Misses 470 472 +2
- Partials 172 173 +1
Continue to review full report at Codecov.
|
prryplatypus
previously approved these changes
Feb 12, 2022
|
I don't understand how any of my changes correlate to the tests failing. 🤔 |
ahopkins
requested changes
Feb 12, 2022
prryplatypus
approved these changes
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When looking through the documentation I was unable to find these two methods, without docstrings these methods do not show up in the autogenerated documentation.
There's not much more to say about this change.