Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better exception for bad URL parse #2415

Merged
merged 2 commits into from Mar 24, 2022
Merged

Better exception for bad URL parse #2415

merged 2 commits into from Mar 24, 2022

Conversation

ahopkins
Copy link
Member

Fixes #2394

@ahopkins ahopkins requested a review from a team as a code owner March 24, 2022 17:45
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #2415 (54c55f6) into main (0309874) will increase coverage by 0.015%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##              main     #2415       +/-   ##
=============================================
+ Coverage   87.226%   87.242%   +0.015%     
=============================================
  Files           60        60               
  Lines         5034      5040        +6     
  Branches       907       907               
=============================================
+ Hits          4391      4397        +6     
  Misses         472       472               
  Partials       171       171               
Impacted Files Coverage Δ
sanic/exceptions.py 98.837% <100.000%> (+0.027%) ⬆️
sanic/request.py 96.231% <100.000%> (+0.044%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0309874...54c55f6. Read the comment docs.

@ahopkins ahopkins merged commit 0cb342a into main Mar 24, 2022
@ahopkins ahopkins deleted the better-bad-url-error branch March 24, 2022 22:22
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL parse needs better error
1 participant