Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve warning issue with error handler mismatch warning #2452

Merged
merged 1 commit into from May 11, 2022
Merged

Conversation

ahopkins
Copy link
Member

Resolve #2450

@ahopkins ahopkins requested a review from a team as a code owner May 10, 2022 19:32
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #2452 (e4432bf) into main (5d683c6) will decrease coverage by 0.059%.
The diff coverage is 100.000%.

@@              Coverage Diff              @@
##              main     #2452       +/-   ##
=============================================
- Coverage   87.225%   87.166%   -0.060%     
=============================================
  Files           60        60               
  Lines         5057      5057               
  Branches       909       909               
=============================================
- Hits          4411      4408        -3     
- Misses         475       477        +2     
- Partials       171       172        +1     
Impacted Files Coverage Δ
sanic/handlers.py 95.384% <100.000%> (ø)
sanic/server/protocols/http_protocol.py 84.523% <0.000%> (-3.572%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d683c6...e4432bf. Read the comment docs.

@ahopkins ahopkins merged commit 293278b into main May 11, 2022
@ahopkins ahopkins deleted the issue2450 branch May 11, 2022 06:36
ChihweiLHBird pushed a commit to ChihweiLHBird/sanic that referenced this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Handler mismatch warning
1 participant