Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(websocket): ASGI websocket must pass thru bytes as is #2651

Merged
merged 4 commits into from Feb 5, 2023
Merged

Conversation

SaidBySolo
Copy link
Member

fix #2644

@SaidBySolo SaidBySolo requested a review from a team as a code owner January 8, 2023 03:15
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Base: 88.583% // Head: 88.686% // Increases project coverage by +0.102% 🎉

Coverage data is based on head (636057b) compared to base (c7a71cd).
Patch coverage: 100.000% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2651       +/-   ##
=============================================
+ Coverage   88.583%   88.686%   +0.102%     
=============================================
  Files           87        87               
  Lines         6850      6850               
  Branches      1171      1171               
=============================================
+ Hits          6068      6075        +7     
+ Misses         540       535        -5     
+ Partials       242       240        -2     
Impacted Files Coverage Δ
sanic/server/websockets/connection.py 81.395% <100.000%> (+6.976%) ⬆️
sanic/server/websockets/impl.py 38.479% <0.000%> (+0.921%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ahopkins ahopkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test

Copy link
Member Author

@SaidBySolo SaidBySolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the existing test_websocket_receive test function was changed.

test_websocket_receive -> test_websocket_text_receive

tests/test_asgi.py Outdated Show resolved Hide resolved
@ahopkins ahopkins merged commit 5e7f699 into main Feb 5, 2023
@ahopkins ahopkins deleted the fix/gh-2644 branch February 5, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASGI websocket must pass thru bytes as is
3 participants