Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated property in blueprint #2666

Merged
merged 1 commit into from Jan 30, 2023

Conversation

r0x0d
Copy link
Contributor

@r0x0d r0x0d commented Jan 27, 2023

The future.handler.__blueprintname__ is not used anymore in the blueprint module, hence, removing legacy code.

Fixes #2442

Signed-off-by: Rodolfo Olivieri rodolfo.olivieri3@gmail.com

@r0x0d r0x0d requested a review from a team as a code owner January 27, 2023 03:04
The `future.handler.__blueprintname__` is not used anymore in the
blueprint module, hence, removing legacy code.

Fixes sanic-org#2442

Signed-off-by: Rodolfo Olivieri <rodolfo.olivieri3@gmail.com>
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 88.650% // Head: 88.649% // Decreases project coverage by -0.002% ⚠️

Coverage data is based on head (4f45a80) compared to base (4ad8168).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2666       +/-   ##
=============================================
- Coverage   88.650%   88.649%   -0.002%     
=============================================
  Files           82        82               
  Lines         6767      6766        -1     
  Branches      1156      1156               
=============================================
- Hits          5999      5998        -1     
  Misses         531       531               
  Partials       237       237               
Impacted Files Coverage Δ
sanic/blueprints.py 91.133% <ø> (-0.044%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 30c53b6 into sanic-org:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate __blueprintname__
2 participants