Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer traceback formatting #2667

Merged
merged 68 commits into from Mar 6, 2023
Merged

Nicer traceback formatting #2667

merged 68 commits into from Mar 6, 2023

Commits on Jan 24, 2023

  1. Establish basic file browser and index fallback

    @ahopkins
    ahopkins committed Jan 24, 2023
    Copy the full SHA
    6673acf View commit details
    Browse the repository at this point in the history

  2. Remove location information

    @ahopkins
    ahopkins committed Jan 24, 2023
    Copy the full SHA
    fed2ef3 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Use html5tagger for AutoIndex

    @ahopkins
    ahopkins committed Jan 25, 2023
    Copy the full SHA
    36e3cc9 View commit details
    Browse the repository at this point in the history

  2. Valid HTML5

    @ahopkins
    ahopkins committed Jan 25, 2023
    Copy the full SHA
    e8bb283 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Add new pages module

    @ahopkins
    ahopkins committed Jan 26, 2023
    Copy the full SHA
    39a4a75 View commit details
    Browse the repository at this point in the history

  2. Refactor to allow for common pages

    @ahopkins
    ahopkins committed Jan 26, 2023
    Copy the full SHA
    2e36507 View commit details
    Browse the repository at this point in the history

  3. No logging of exception

    @ahopkins
    ahopkins committed Jan 26, 2023
    Copy the full SHA
    ca0e933 View commit details
    Browse the repository at this point in the history

  4. squash

    @ahopkins
    ahopkins committed Jan 26, 2023
    Copy the full SHA
    2c8f180 View commit details
    Browse the repository at this point in the history

  5. Style fixes for file table

    @ahopkins
    ahopkins committed Jan 26, 2023
    Copy the full SHA
    fa6dbdd View commit details
    Browse the repository at this point in the history

  6. Simple server to include autoindex

    @ahopkins
    ahopkins committed Jan 26, 2023
    Copy the full SHA
    10d4f28 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Add a header bar with Sanic logo. Remove duplicate title element. Avo… 

    …id escaping in style element and add new styles.
    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    d9c883e View commit details
    Browse the repository at this point in the history

  2. Timestamps a bit less ugly.

    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    e328d44 View commit details
    Browse the repository at this point in the history

  3. Improve navigation with breadcrumbs

    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    41da8bb View commit details
    Browse the repository at this point in the history

  4. Remove parent directory link from table

    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    2038799 View commit details
    Browse the repository at this point in the history

  5. Fix Sanic brand colour in breadcrumbs.

    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    859a813 View commit details
    Browse the repository at this point in the history

  6. Better UX for empty folders.

    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    a00ec8a View commit details
    Browse the repository at this point in the history

  7. Style tweaks

    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    32d62c2 View commit details
    Browse the repository at this point in the history

  8. URL sanitation.

    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    b517523 View commit details
    Browse the repository at this point in the history

  9. Fix the document title (needs positional argument).

    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    faf1ff8 View commit details
    Browse the repository at this point in the history

  10. HTML error formatting rebuilt on top of BasePage, and using external … 

    …module niceback to do the tracebacks.
    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    77bdfa1 View commit details
    Browse the repository at this point in the history

  11. Refactored to sanic.pages.error module. Traceback and style tuning. P… 

    …rint also headers, and for other than 500 errors as well. 500 error message text UX workaround.
    @Tronic
    Tronic committed Jan 27, 2023
    Copy the full SHA
    ea09906 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. Move DirectoryHandler to app instance

    @ahopkins
    ahopkins committed Jan 28, 2023
    Copy the full SHA
    f30f53f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue2661' into niceback-error-handling

    @Tronic
    Tronic committed Jan 28, 2023
    Copy the full SHA
    ae757c8 View commit details
    Browse the repository at this point in the history

  3. Define colors for light/default mode as well. 

    The background is not always white by default (e.g. when in an iframe), so it needs to be defined or text may become invisible (just had this problem today). I've taken the opportunity to make it slightly less bright as well.
    @Tronic
    Tronic committed Jan 28, 2023
    Copy the full SHA
    4f000ab View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Set styles

    @ahopkins
    ahopkins committed Jan 31, 2023
    Copy the full SHA
    b46b81d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'issue2661' of github.com:sanic-org/sanic into issue2661

    @ahopkins
    ahopkins committed Jan 31, 2023
    Copy the full SHA
    713abe3 View commit details
    Browse the repository at this point in the history

  3. No auto registration of fallback error handlers

    @ahopkins
    ahopkins committed Jan 31, 2023
    Copy the full SHA
    1b43aa5 View commit details
    Browse the repository at this point in the history

  4. Remove accidental file

    @ahopkins
    ahopkins committed Jan 31, 2023
    Copy the full SHA
    ddf3a49 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of github.com:sanic-org/sanic into issue2661

    @ahopkins
    ahopkins committed Jan 31, 2023
    Copy the full SHA
    5dfd48f View commit details
    Browse the repository at this point in the history

  6. Sans serif w/ autoindex monospace

    @ahopkins
    ahopkins committed Jan 31, 2023
    Copy the full SHA
    2df5b19 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Merge branch 'issue2661' into niceback-error-handling

    @Tronic
    Tronic committed Feb 2, 2023
    Copy the full SHA
    ff47448 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Minor style changes, loading TraceRite style and css properly, printi… 

    …ng exception extra data.
    @Tronic
    Tronic committed Feb 4, 2023
    Copy the full SHA
    ebc2f46 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2023

  1. Merge branch 'main' into niceback-error-handling

    @Tronic
    Tronic committed Feb 5, 2023
    Copy the full SHA
    53b7a5a View commit details
    Browse the repository at this point in the history

  2. CSS fixes, incl. scaling layout for small screens.

    @Tronic
    Tronic committed Feb 5, 2023
    Copy the full SHA
    f4792a2 View commit details
    Browse the repository at this point in the history

  3. CSS files now start with comments, none inserted in code.

    @Tronic
    Tronic committed Feb 5, 2023
    Copy the full SHA
    5c65118 View commit details
    Browse the repository at this point in the history

  4. setup.py

    @Tronic
    Tronic committed Feb 5, 2023
    Copy the full SHA
    207f8af View commit details
    Browse the repository at this point in the history

  5. Fallback for route name when no route found.

    @Tronic
    Tronic committed Feb 5, 2023
    Copy the full SHA
    a6ff13c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' of github.com:sanic-org/sanic into niceback-error… 

    …-handling
    @ahopkins
    ahopkins committed Feb 5, 2023
    Copy the full SHA
    d6f2613 View commit details
    Browse the repository at this point in the history

  7. CSS loading with STYLE_APPEND

    @Tronic
    Tronic committed Feb 5, 2023
    Copy the full SHA
    cf76c05 View commit details
    Browse the repository at this point in the history

  8. Require tracerite=>1.0.0

    @Tronic
    Tronic committed Feb 5, 2023
    Copy the full SHA
    783a29b View commit details
    Browse the repository at this point in the history

  9. Merge branch 'niceback-error-handling' of github.com:sanic-org/sanic … 

    …into niceback-error-handling
    @ahopkins
    ahopkins committed Feb 5, 2023
    Copy the full SHA
    7491d56 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. Suggestions

    @ahopkins
    ahopkins committed Feb 6, 2023
    Copy the full SHA
    47b2459 View commit details
    Browse the repository at this point in the history

  2. Cleanup styles and add Sanic palette

    @ahopkins
    ahopkins committed Feb 6, 2023
    Copy the full SHA
    a773ad2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into niceback-error-handling

    @Tronic
    Tronic committed Feb 6, 2023
    Copy the full SHA
    68bf26d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'html-error-handling-suggestions' into niceback-error-ha… 

    …ndling
    @Tronic
    Tronic committed Feb 6, 2023
    Copy the full SHA
    3ddbda6 View commit details
    Browse the repository at this point in the history

  5. Logo shadow to make it show up on white background.

    @Tronic
    Tronic committed Feb 6, 2023
    Copy the full SHA
    39b98e6 View commit details
    Browse the repository at this point in the history

  6. Some Sanic branding to error page (#2673) 

    * Some Sanic branding to error page

* Simplify logo compat
    @ahopkins
    ahopkins committed Feb 6, 2023
    Copy the full SHA
    12ba685 View commit details
    Browse the repository at this point in the history

  7. Fix SVG: alt to desc, whitespace removed

    @Tronic
    Tronic committed Feb 6, 2023
    Copy the full SHA
    526115c View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Add traceback suppressions to commonly shown internals.

    @Tronic
    Tronic committed Feb 7, 2023
    Copy the full SHA
    da9ff33 View commit details
    Browse the repository at this point in the history

  2. Cleanup.

    @Tronic
    Tronic committed Feb 7, 2023
    Copy the full SHA
    a6efebd View commit details
    Browse the repository at this point in the history

  3. Implement key-value-table as dl instead of table element.

    @Tronic
    Tronic committed Feb 7, 2023
    Copy the full SHA
    ce19908 View commit details
    Browse the repository at this point in the history

  4. Style and layout changes, fix document title.

    @Tronic
    Tronic committed Feb 7, 2023
    Copy the full SHA
    a5f732c View commit details
    Browse the repository at this point in the history

  5. Misc styling

    @Tronic
    Tronic committed Feb 7, 2023
    Copy the full SHA
    7e617c1 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Friendlify the error page.

    @Tronic
    Tronic committed Feb 8, 2023
    Copy the full SHA
    37f3607 View commit details
    Browse the repository at this point in the history

  2. Fix scrollbar layout problems.

    @Tronic
    Tronic committed Feb 8, 2023
    Copy the full SHA
    4c55051 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Color tweaks for Error Handling. (#2676) 

    * Add color sections for dark mode

* Tweak colors for light mode

* Tweak colors for dark mode

* Remove tab styling

* Remove forced hanging emoji from error header

* Add padding for main container so text doesn’t touch screen boundary

* invalid text justify css

* Tweak color scheme for dark themes

* Add margins for h3. Probably should be done in the tracerite package.

* Add tracerite tab color with new sanic-tab variable.

* Soften lightmode text color

* Define sanic-background, sanic-text as top-level colors. Restructure color schemes to top of definition.

* Define highlight and tab colors as variables

* Add tab hover shadow definition. Intended to have better hover accents for light theme.

* Ensure sanic brand color be the same in dark mode.

* Add header background, change all dark theme grays to neutral grays.

* Switch blue to code block orange in sanic docs. Add sanic highlight override. Add darker sanic background (111) as option but in the comments so we can switch back if need be.

* Add sanic id to top level document.

* Use hsl and rgba for dark themed background so that they can be easily changed and nudged.

* Change colors to Adam’s preferences.

* Remove important from css after adding sanic as id,

* Remove remnants of “important” for pre and code tags. Add Meslo in font.
    @smlbiobot
    smlbiobot committed Mar 1, 2023
    Copy the full SHA
    c328a3c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into niceback-error-handling

    @Tronic
    Tronic committed Mar 1, 2023
    Copy the full SHA
    1332e61 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Use exc.quiet to determine whether details should be open by default

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    cf239a0 View commit details
    Browse the repository at this point in the history

  2. Make full() and minimal() identical.

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    114456b View commit details
    Browse the repository at this point in the history

  3. Remove old error page formatting.

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    f3cd637 View commit details
    Browse the repository at this point in the history

  4. Cleanup

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    2be6376 View commit details
    Browse the repository at this point in the history

  5. Update tests for new error pages

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    35aaa62 View commit details
    Browse the repository at this point in the history

  6. isort

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    384c963 View commit details
    Browse the repository at this point in the history

  7. Typing

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    fc5c2df View commit details
    Browse the repository at this point in the history

  8. Suppress mypy for tracerite while it doesn't have typing stub

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    1cf23f2 View commit details
    Browse the repository at this point in the history

  9. Change requests

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    8b0ffbb View commit details
    Browse the repository at this point in the history

  10. Sanic pages coloring (#2703) 

    * tracerite var colors

* Simplified parse_content_header escaping (#2707)

* Move comments, darken bg color, move debug links to contextmanager

* Lineup H2s

* Make pretty

---------

Co-authored-by: L. Kärkkäinen <98187+Tronic@users.noreply.github.com>
    @ahopkins @Tronic
    ahopkins and Tronic committed Mar 6, 2023
    Copy the full SHA
    ee290ba View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into niceback-error-handling

    @Tronic
    Tronic committed Mar 6, 2023
    Copy the full SHA
    ff0f3e6 View commit details
    Browse the repository at this point in the history