Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logging format to %s #2721

Merged
merged 2 commits into from Mar 20, 2023
Merged

Change logging format to %s #2721

merged 2 commits into from Mar 20, 2023

Conversation

ahopkins
Copy link
Member

Closes #2677

@ahopkins ahopkins requested a review from a team as a code owner March 20, 2023 08:57
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.019 🎉

Comparison is base (53820bc) 88.617% compared to head (ab30a43) 88.637%.

❗ Current head ab30a43 differs from pull request most recent head 9a82246. Consider uploading reports for the commit 9a82246 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2721       +/-   ##
=============================================
+ Coverage   88.617%   88.637%   +0.019%     
=============================================
  Files           87        87               
  Lines         6844      6838        -6     
  Branches      1178      1176        -2     
=============================================
- Hits          6065      6061        -4     
+ Misses         537       535        -2     
  Partials       242       242               
Impacted Files Coverage Δ
sanic/log.py 100.000% <ø> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit a245ab3 into main Mar 20, 2023
30 checks passed
@ahopkins ahopkins deleted the issue2677 branch March 20, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access logging raise TypeError after logging.logProcesses=False
3 participants