Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traversals for intended results #2728

Merged
merged 3 commits into from Jul 9, 2023
Merged

Fix traversals for intended results #2728

merged 3 commits into from Jul 9, 2023

Conversation

ahopkins
Copy link
Member

Closes #2726

@ahopkins ahopkins requested a review from a team as a code owner March 30, 2023 08:27
@ahopkins ahopkins requested a review from a team as a code owner March 30, 2023 08:29
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.000% and project coverage change: +0.019 🎉

Comparison is base (e374409) 88.919% compared to head (dd54f48) 88.938%.

❗ Current head dd54f48 differs from pull request most recent head 0e9fa30. Consider uploading reports for the commit 0e9fa30 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2728       +/-   ##
=============================================
+ Coverage   88.919%   88.938%   +0.019%     
=============================================
  Files           92        92               
  Lines         6976      6952       -24     
  Branches      1190      1185        -5     
=============================================
- Hits          6203      6183       -20     
+ Misses         529       527        -2     
+ Partials       244       242        -2     
Impacted Files Coverage Δ
sanic/__version__.py 100.000% <100.000%> (ø)
sanic/mixins/static.py 89.928% <100.000%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanic-org sanic-org deleted a comment from github-advanced-security bot Mar 30, 2023
ChihweiLHBird
ChihweiLHBird previously approved these changes Jun 19, 2023
@ahopkins ahopkins changed the base branch from current-release to main July 9, 2023 06:00
@ahopkins ahopkins dismissed ChihweiLHBird’s stale review July 9, 2023 06:00

The base branch was changed.

@ahopkins ahopkins merged commit 049983c into main Jul 9, 2023
30 checks passed
@ahopkins ahopkins deleted the issue2726 branch July 9, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static routes containing ".." don't work
3 participants