Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run keep alive tests in loop to get available port #2779

Merged
merged 3 commits into from Jul 9, 2023

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jul 9, 2023

This pesky test...

The issue is in getting an available port. So, let's just let it loop until it gets one it likes.

@ahopkins ahopkins requested a review from a team as a code owner July 9, 2023 19:21
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (666371b) 88.844% compared to head (5899345) 88.844%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2779   +/-   ##
=========================================
  Coverage   88.844%   88.844%           
=========================================
  Files           92        92           
  Lines         7001      7001           
  Branches      1194      1194           
=========================================
  Hits          6220      6220           
  Misses         533       533           
  Partials       248       248           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 6848ff2 into main Jul 9, 2023
51 checks passed
@ahopkins ahopkins deleted the keep-alive-loop-test branch July 9, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants