Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request.client_ip #2790

Merged
merged 2 commits into from Jul 13, 2023
Merged

Add request.client_ip #2790

merged 2 commits into from Jul 13, 2023

Conversation

Tronic
Copy link
Member

@Tronic Tronic commented Jul 13, 2023

This has been on TODO forever. I think it is time to get it sorted out. The name client_ip matches what others are calling this (Caddy just implemented the same thing).

@Tronic Tronic requested a review from a team as a code owner July 13, 2023 13:48
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 100.000% and project coverage change: +0.004 🎉

Comparison is base (dc3c4d1) 88.906% compared to head (ffffc7c) 88.911%.

❗ Current head ffffc7c differs from pull request most recent head 809e64a. Consider uploading reports for the commit 809e64a to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2790       +/-   ##
=============================================
+ Coverage   88.906%   88.911%   +0.004%     
=============================================
  Files           92        92               
  Lines         7031      7034        +3     
  Branches      1195      1195               
=============================================
+ Hits          6251      6254        +3     
  Misses         534       534               
  Partials       246       246               
Impacted Files Coverage Δ
sanic/request/types.py 94.957% <100.000%> (+0.042%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahopkins ahopkins merged commit 31d7ba8 into main Jul 13, 2023
25 checks passed
@ahopkins ahopkins deleted the client_ip branch July 13, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants