Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner process management #2811

Merged
merged 13 commits into from
Dec 7, 2023
Merged

Cleaner process management #2811

merged 13 commits into from
Dec 7, 2023

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Aug 29, 2023

This is meant to cleanup the process of shutting the server and processes down in a more controlled manner. It should avoid some of the problems we have seen in the past of sneaky race conditions popping in from time to time in the cleanup process.

Closes #2809

@ahopkins ahopkins marked this pull request as ready for review December 5, 2023 11:27
@ahopkins ahopkins requested a review from a team as a code owner December 5, 2023 11:27
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (00f2af2) 88.369% compared to head (59bb9c6) 88.191%.

Files Patch % Lines
sanic/mixins/startup.py 57.142% 5 Missing and 1 partial ⚠️
sanic/worker/multiplexer.py 28.571% 5 Missing ⚠️
sanic/worker/process.py 58.333% 4 Missing and 1 partial ⚠️
sanic/app.py 50.000% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##              main     #2811       +/-   ##
=============================================
- Coverage   88.369%   88.191%   -0.179%     
=============================================
  Files           92        93        +1     
  Lines         7188      7232       +44     
  Branches      1234      1242        +8     
=============================================
+ Hits          6352      6378       +26     
- Misses         581       597       +16     
- Partials       255       257        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins ahopkins merged commit 4499d2c into main Dec 7, 2023
26 checks passed
@ahopkins ahopkins deleted the smoother-process-management branch December 7, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

main_process_stop runs BEFORE before_server_stop when interrupted with SIGINT
1 participant