Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress task cancel traceback #2812

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Suppress task cancel traceback #2812

merged 2 commits into from
Aug 30, 2023

Conversation

ahopkins
Copy link
Member

If you have an open websocket when the server shutsdown (or restarts), there is an annoying traceback for the recv. This PR properly cancels that task so that it does not clutter logs.

@ahopkins ahopkins requested a review from a team as a code owner August 29, 2023 17:47
Copy link
Member

@prryplatypus prryplatypus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E

@ahopkins ahopkins merged commit 38ff906 into main Aug 30, 2023
25 checks passed
@ahopkins ahopkins deleted the websocket-cancel branch August 30, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants