2882 Apply dynamic port fixture for tests of cli, config and server …

[iAndriy]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.012%. Comparing base (afe4f27) to head (1889d91).

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #2892   +/-   ##
=========================================
  Coverage   88.012%   88.012%           
=========================================
  Files           94        94           
  Lines         7408      7408           
  Branches      1307      1307           
=========================================
  Hits          6520      6520           
  Misses         598       598           
  Partials       290       290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Tronic]

There is a race condition in get_port because the socket opened is closed when returning the function so another process running at the same time could accidentally get the same port. If it instead returned the socket, that was then used with server, there would be no such issue, but that cannot work with CLI tests where no socket can be passed.

Alternatively, simply picking a random int would possibly be faster and still only very rarely have collisions. Presumably the kernel essentially picks a random number each time we bind to port 0, so this might be close to current behavior.