Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken multiplexer manage #2895

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Fix broken multiplexer manage #2895

merged 1 commit into from
Jan 9, 2024

Conversation

ahopkins
Copy link
Member

@ahopkins ahopkins commented Jan 9, 2024

Fixes #2894

@ahopkins ahopkins requested a review from a team as a code owner January 9, 2024 07:51
@ahopkins ahopkins requested a review from a team as a code owner January 9, 2024 07:53
@ahopkins ahopkins changed the base branch from main to 23.12LTS January 9, 2024 07:54
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3d85a1c) 88.026% compared to head (6df4767) 87.999%.

Files Patch % Lines
sanic/worker/manager.py 0.000% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           23.12LTS     #2895       +/-   ##
==============================================
- Coverage    88.026%   87.999%   -0.027%     
==============================================
  Files            94        94               
  Lines          7433      7433               
  Branches       1283      1283               
==============================================
- Hits           6543      6541        -2     
- Misses          623       624        +1     
- Partials        267       268        +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahopkins ahopkins merged commit 599f746 into 23.12LTS Jan 9, 2024
27 checks passed
@ahopkins ahopkins deleted the multiplexer-manage-bug branch January 9, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiplexer and Manager out of sync on number of expected arguments
1 participant