Remove erroneous del line #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line tries to delete a list element that has never been added, so it raises an error when reached. Fixes sanic-org#2889
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2899 +/- ##
=============================================
- Coverage 87.999% 87.985% -0.014%
=============================================
Files 94 94
Lines 7408 7408
Branches 1307 1307
=============================================
- Hits 6519 6518 -1
- Misses 598 599 +1
Partials 291 291 ☔ View full report in Codecov by Sentry. |
|
Running into this myself, would appreciate this getting merged! |
prryplatypus
approved these changes
Jan 21, 2024
ahopkins
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line tries to delete a list element that has never been added, so it raises an error when reached.
Fixes #2889