Added multiprocessing #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salamer
reviewed
Oct 18, 2016
| from inspect import isawaitable | ||
| from multiprocessing import Process, Event |
There was a problem hiding this comment.
I think the multiprocess function should not contain in the program, just let user to decide use multi process or not
| from inspect import isawaitable | ||
| from multiprocessing import Process, Event |
There was a problem hiding this comment.
I think the multiprocess function should not contain in the program, just let user to decide use multi process or not
There was a problem hiding this comment.
If run is executed with 1 worker, it won't use multiprocessing. Should we not import it by default? I thought it would be okay since it's part of the standard library.
This was referenced Oct 18, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.