allow disabling keep alive

[r0fls]

Fixes: #637

[messense]

@property
def keep_alive(self):
    return (not self._no_keep_alive
            and not self.signal.stopped
            and self.parser.should_keep_alive())

Would be better?

[r0fls]

Well this does get loaded from config here: https://github.com/channelcat/sanic/pull/646/files#diff-c4444a35dbd5e37ee480b0e8888e0880R682

How does #639 apply exactly?

[38elements]

I am sorry.
I was misunderstanding for config.

[r0fls]

Do we think the variable makes more sense as just KEEP_ALIVE vs NO_KEEP_ALIVE?

[38elements]

No, just I did not read config.py.
I think that NO_KEEP_ALIVE is good.

[38elements]

About #639, it occurred when I implemented a similar test.

[38elements]

I am sorry for changing my opinion.
Because I feel that KEEP_ALIVE is more common, I think that KEEP_ALIVE is better.

[r0fls]

No worries, I think I agree so better late than never :) I'll update it to use that...

[38elements]

Thanks.

[38elements]

I think that it is better to add tests for that keep alive is valid and invalid.
For #639, I think that the test when keep alive is valid will be difficult.

[38elements]

@r0fls
I understood the cause.
I commented in #639.
Would you implement this and add tests?

[38elements]

My English is not good.
I am sorry if I confused you.

[r0fls]

No you're English is fine. I'm just traveling. I'll try to add the test soon thank you. If you have an idea for it in mind you can put it here otherwise I'll plan to do it soon...

[38elements]

Thanks.