Add the killing of children

[seemethere]

Kills children processes when parent process receives a signal to
shutdown.

Solves for #594

[r0fls]

Unfortunately this doesn't work. To illustrate, the below can be app.py:

from sanic import Sanic
from sanic.response import json

app = Sanic(__name__)


@app.route("/")
async def test(request):
    return json({"test": True})

app.static('/', './')

if __name__ == '__main__':
    app.run(host="0.0.0.0", port=8000, workers=3)

then kill the lowest number process (find it with ps aux | grep app.py). You can see the others are still running (again with ps aux | grep app.py.

[seemethere]

No with this you send a sigint to the parent process as originally stated in the issue

…

On Thu, Apr 27, 2017, 7:54 PM Raphael Deem ***@***.***> wrote: ***@***.**** commented on this pull request. Unfortunately this doesn't work. To illustrate, the below can be app.py: from sanic import Sanic from sanic.response import json app = Sanic(__name__) @app.route("/") async def test(request): return json({"test": True}) app.static('/', './') if __name__ == '__main__': app.run(host="0.0.0.0", port=8000, workers=3) then kill the lowest number process (find it with ps aux | grep app.py). You can see the others are still running (again with ps aux | grep app.py. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#668 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABnz1z8iPdEbhxcNaXPqUXEmjqpfnAXlks5r0VTZgaJpZM4NK7jZ> .

[r0fls]

the parent process

This is what I meant by the lowest number process listed in ps aux | grep app.py, as the parent process number is not displayed for me during sanic startup.

[r0fls]

I thought this was working a long time ago 👿

[seemethere]

Are you sure you're killing the parent process? When I did it with an os.getpid() it seemed to work fine.

[r0fls]

derp, i was sending a kill signal not int. kill -2 parent_pid works

[r0fls]

nice title btw, much like the god cronos

[seemethere]

You know how I do :D