Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::Music::Opera (#1619) #39

Merged
merged 1 commit into from Jun 6, 2019

Conversation

sanikkenway
Copy link
Owner

  • added tests and corrected yaml

  • corrected test

  • fixed missing magic comment and missing spaces

  • added dashed array in yml and doc

  • moved opera.md to doc/music/opera.md and added link to it in ureleased_README

  • moved test_faker_opera to faker/music directory

  • corrected path to test_helper in test_faker_opera.rb

  • moved opera.md to doc unreleased

  • restarted pr

* added tests and corrected yaml

* corrected test

* fixed missing magic comment and missing spaces

* added dashed array in yml and doc

* moved opera.md to doc/music/opera.md and added link to it in ureleased_README

* moved test_faker_opera to faker/music directory

* corrected path to test_helper in test_faker_opera.rb

* moved opera.md to doc unreleased

* restarted pr
@sanikkenway sanikkenway merged commit d2cb478 into sanikkenway:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants