Skip to content

Commit

Permalink
馃帹 Get fragment categories defaults from towncrier
Browse files Browse the repository at this point in the history
Resolves #17
  • Loading branch information
webknjaz committed Aug 3, 2019
1 parent 0a112ca commit 47455b9
Show file tree
Hide file tree
Showing 3 changed files with 30 additions and 9 deletions.
24 changes: 15 additions & 9 deletions chronographer/event_handlers.py
Expand Up @@ -23,6 +23,20 @@
LABEL_PROVIDED,
)

try:
from towncrier._settings import _default_types as _towncrier_default_types
FALLBACK_CHANGE_TYPES = tuple(_towncrier_default_types)
except ImportError:
FALLBACK_CHANGE_TYPES = (
'bugfix',
'doc',
'feature',
'misc',
'removal',
'trivial',
'vendor',

This comment has been minimized.

Copy link
@pradyunsg

pradyunsg Aug 3, 2019

Collaborator

This probably shouldn't be here.

This comment has been minimized.

Copy link
@webknjaz

webknjaz Aug 7, 2019

Author Member

@pradyunsg What do you mean? This fallback is probably good enough. This list was copy-pasted from browntruck.

This comment has been minimized.

Copy link
@pradyunsg

pradyunsg Aug 7, 2019

Collaborator

Oh, sorry. I think some of these are pip specific and shouldn't be in the general list IMO.

This comment has been minimized.

Copy link
@webknjaz

webknjaz Aug 7, 2019

Author Member

this will probably never happen: even though I use a private variable from a private module the deps are pinned properly.

This comment has been minimized.

Copy link
@pradyunsg

pradyunsg Aug 8, 2019

Collaborator

Yea true. I'm just nit picking. 馃檲

)


logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -255,14 +269,6 @@ async def on_pr(event):
async def compile_towncrier_fragments_regex(ref, name_settings):
"""Create fragments check regex based on the towncrier config."""
fallback_base_dir = 'news'
fallback_change_types = (
'bugfix',
'doc',
'feature',
'removal',
'trivial',
'vendor',
)

# e.g. ``.rst``:
fragment_filename_suffix = re.escape(name_settings.get('suffix', ''))
Expand All @@ -274,7 +280,7 @@ async def compile_towncrier_fragments_regex(ref, name_settings):
)
change_types = (
tuple(t['directory'] for t in towncrier_conf.get('type', ()))
or fallback_change_types
or FALLBACK_CHANGE_TYPES
)

# Ref:
Expand Down
14 changes: 14 additions & 0 deletions constraints.txt
Expand Up @@ -9,6 +9,8 @@ certifi==2018.11.29 --hash=sha256:993f830721089fef441cdfeb4b2c8c9df86f0c63239f06
cffi==1.11.5 --hash=sha256:a6a5cb8809091ec9ac03edde9304b3ad82ad4466333432b16d78ef40e0cce0d5
cfgv==1.1.0 --hash=sha256:73f48a752bd7aab103c4b882d6596c6360b7aa63b34073dd2c35c7b4b8f93010
chardet==3.0.4 --hash=sha256:fc323ffcaeaed0e0a02bf4d117757b98aed530d9ed4531e3e15460124c106691
Click==7.0 --hash=sha256:2335065e6395b9e67ca716de5f7526736bfa6ceead690adf616d925bdc622b13 \
--hash=sha256:5b94b49521f6456670fdb30cd82a4eca9412788a93fa6dd6df72c94d5a8ff2d7
cryptography==2.4.2 --hash=sha256:70596e90398574b77929cd87e1ac6e43edd0e29ba01e1365fed9c26bde295aa5
Deprecated==1.2.4 --hash=sha256:8bfeba6e630abf42b5d111b68a05f7fe3d6de7004391b3cd614947594f87a4ff
environ_config==18.2.0 --hash=sha256:1bdec05c515676e0de2b794c10de4ceee9709b416945646a1f5bed5714a9cc29
Expand All @@ -18,8 +20,18 @@ gunicorn==19.9.0 --hash=sha256:aa8e0b40b4157b36a5df5e599f45c9c76d6af43845ba3b3b0
identify==1.1.7 --hash=sha256:623086059219cc7b86c77a3891f3700cb175d4ce02b8fb8802b047301d71e783
idna==2.7 --hash=sha256:156a6814fb5ac1fc6850fb002e0852d56c0c8d2531923a51032d1b70760e186e
importlib-metadata==0.7 --hash=sha256:4a545e6125dc72b4ad98201ea3f40f92e8126e3a19667352b3a134d22b8bc74f
incremental==17.5.0 --hash=sha256:717e12246dddf231a349175f48d74d93e2897244939173b01974ab6661406b9f \
--hash=sha256:7b751696aaf36eebfab537e458929e194460051ccad279c72b755a167eebd4b3
isort==4.3.4 --hash=sha256:1153601da39a25b14ddc54955dbbacbb6b2d19135386699e2ad58517953b34af
jinja2==2.10.1 --hash=sha256:14dd6caf1527abb21f08f86c784eac40853ba93edb79552aa1e4b8aef1b61c7b \
--hash=sha256:065c4f02ebe7f7cf559e49ee5a95fb800a9e4528727aec6f24402a5374c65013
lazy-object-proxy==1.3.1 --hash=sha256:eb91be369f945f10d3a49f5f9be8b3d0b93a4c2be8f8a5b83b0571b8123e0a7a
MarkupSafe==1.1.1 --hash=sha256:8defac2f2ccd6805ebf65f5eeb132adcf2ab57aa11fdf4c0dd5169a004710e7d \
--hash=sha256:46c99d2de99945ec5cb54f23c8cd5689f6d7177305ebff350a58ce5f8de1669e \
--hash=sha256:ba59edeaa2fc6114428f1637ffff42da1e311e29382d81b339c1817d37ec93c6 \
--hash=sha256:b00c1de48212e4cc9603895652c5c410df699856a2853135b3967591e4beebc2 \
--hash=sha256:9bf40443012702a1d2070043cb6291650a0841ece432556f784f004937f0f32c \
--hash=sha256:29872e92839765e546828bb7754a68c418d927cd064fd4708fab9fe9c8bb116b
mccabe==0.6.1 --hash=sha256:ab8a6258860da4b6677da4bd2fe5dc2c659cff31b3ee4f7f5d64e79735b80d42
multidict==4.5.2 --hash=sha256:c18498c50c59263841862ea0501da9f2b3659c00db54abfbf823a80787fde8ce
nodeenv==1.3.3 --hash=sha256:ad8259494cf1c9034539f6cced78a1da4840a4b157e23640bc4a0c0546b0cb7a
Expand All @@ -35,6 +47,8 @@ setuptools_scm==3.1.0 --hash=sha256:cc6953d224a22f10e933fa2f55c95979317c55259016
requests==2.21.0 --hash=sha256:7bf2a778576d825600030a110f3c0e3e8edc51dfaafe1c146e39a2027784957b
six==1.11.0 --hash=sha256:832dc0e10feb1aa2c68dcc57dbb658f1c7e65b9b61af69048abc87a2db00a0eb
toml==0.10.0 --hash=sha256:235682dd292d5899d361a811df37e04a8828a5b1da3115886b73cf81ebc9100e
towncrier==19.2.0 --hash=sha256:de19da8b8cb44f18ea7ed3a3823087d2af8fcf497151bb9fd1e1b092ff56ed8d \
--hash=sha256:48251a1ae66d2cf7e6fa5552016386831b3e12bb3b2d08eb70374508c17a8196
unidiff==0.5.5 --hash=sha256:6e7ff4be1a9cd8d72197cd15ec735260b8b95d6f9d3e6fdc8a37301b12af0b27
uritemplate==3.0.0 --hash=sha256:1b9c467a940ce9fb9f50df819e8ddd14696f89b9a8cc87ac77952ba416e0a8fd
urllib3==1.24.1 --hash=sha256:61bf29cada3fc2fbefad4fdf059ea4bd1b4a86d2b6d15e1c7c0b582b9752fe39
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Expand Up @@ -3,4 +3,5 @@ gunicorn
octomachinery
pre-commit
pylint
towncrier
unidiff

0 comments on commit 47455b9

Please sign in to comment.