Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show presence and validation indication #49

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Jul 12, 2023

Seems like the color input in studio v2 never had presence or validation indication. I'm not quite sure if presence actually flows through due to focus broadcasting and subfields, but I don't think it is critical - the most important thing is to indicate validation errors.

Sidenote: v3 ❤️

@rexxars rexxars requested a review from a team July 12, 2023 18:19
Copy link
Contributor

@snorrees snorrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snorrees snorrees merged commit 3b281b7 into studio-v2 Jul 17, 2023
4 checks passed
@snorrees snorrees deleted the fix/v2-validation-presence branch July 17, 2023 11:11
@github-actions
Copy link

🎉 This PR is included in version 2.36.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants