fix(assets): group asset patches per document #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonabc
reviewed
May 17, 2024
mwain
force-pushed
the
fix/CLDX-2167-assets-per-doc
branch
from
7061717
to
42d07b7
Compare
Groups patching of assets per document to reduce lock contention when concurrently
executing mutations.
```
{
"mutations": [
{
"patch": {
"id": "a-doc-id",
"set": {
"pathA.asset": {
"_ref": "image-foo-200x200-png",
"_type": "reference"
},
"pathB.asset": {
"_ref": "image-bar-200x200-png",
"_type": "reference"
}
},
"setIfMissing": {
"pathA": {
"_type": "image"
},
"pathB": {
"_type": "image"
}
}
}
}
]
}
```
mwain
force-pushed
the
fix/CLDX-2167-assets-per-doc
branch
from
42d07b7
to
a7abfa1
Compare
jonabc
approved these changes
May 17, 2024
mwain
added a commit
that referenced
this pull request
Jun 3, 2024
Groups patching of assets per document to reduce lock contention when concurrently
executing mutations.
```
{
"mutations": [
{
"patch": {
"id": "a-doc-id",
"set": {
"pathA.asset": {
"_ref": "image-foo-200x200-png",
"_type": "reference"
},
"pathB.asset": {
"_ref": "image-bar-200x200-png",
"_type": "reference"
}
},
"setIfMissing": {
"pathA": {
"_type": "image"
},
"pathB": {
"_type": "image"
}
}
}
}
]
}
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groups patching of assets per document to reduce lock contention when concurrently executing mutations.