Skip to content

Commit

Permalink
fix: improve bundler output
Browse files Browse the repository at this point in the history
  • Loading branch information
stipsan committed Apr 23, 2024
1 parent 5b7e837 commit 2c62182
Show file tree
Hide file tree
Showing 16 changed files with 76 additions and 71 deletions.
13 changes: 7 additions & 6 deletions packages/next-sanity/package.config.ts
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
import path from 'node:path'

Check warning on line 1 in packages/next-sanity/package.config.ts

View workflow job for this annotation

GitHub Actions / build

Run autofix to sort these imports!
import {defineConfig} from '@sanity/pkg-utils'

const MODULE_PATHS_WHICH_USE_CLIENT_DIRECTIVE_SHOULD_BE_ADDED = [
'NextStudio.tsx',
'VisualEditing.tsx',
'imageLoader.ts',
path.join('src', 'image', 'index.ts'),
path.join('src', 'studio', 'client-component', 'index.ts'),
path.join('src', 'visual-editing', 'client-component', 'index.ts'),
]

const MODULE_PATHS_WHICH_USE_SERVER_DIRECTIVE_SHOULD_BE_ADDED = ['actions.ts']
const MODULE_PATHS_WHICH_USE_SERVER_DIRECTIVE_SHOULD_BE_ADDED = [
path.join('src', 'visual-editing', 'server-actions', 'index.ts'),
]

export default defineConfig({
tsconfig: 'tsconfig.build.json',
minify: true,
rollup: {
output: {
preserveModules: true,
preserveModulesRoot: 'src',
banner: (chunkInfo) => {
if (
MODULE_PATHS_WHICH_USE_CLIENT_DIRECTIVE_SHOULD_BE_ADDED.find((modulePath) =>
Expand Down
51 changes: 39 additions & 12 deletions packages/next-sanity/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,15 @@
},
"./image": {
"source": "./src/image/index.ts",
"import": "./dist/image/index.js",
"require": "./dist/image/index.cjs",
"default": "./dist/image/index.js"
"import": "./dist/image.js",
"require": "./dist/image.cjs",
"default": "./dist/image.js"
},
"./preview": {
"source": "./src/preview/index.ts",
"import": "./dist/preview/index.js",
"require": "./dist/preview/index.cjs",
"default": "./dist/preview/index.js"
"import": "./dist/preview.js",
"require": "./dist/preview.cjs",
"default": "./dist/preview.js"
},
"./preview/live-query": {
"source": "./src/preview/LiveQuery/index.ts",
Expand All @@ -51,9 +51,27 @@
},
"./studio": {
"source": "./src/studio/index.ts",
"import": "./dist/studio/index.js",
"require": "./dist/studio/index.cjs",
"default": "./dist/studio/index.js"
"import": "./dist/studio.js",
"require": "./dist/studio.cjs",
"default": "./dist/studio.js"
},
"./studio/client-component": {
"source": "./src/studio/client-component/index.ts",
"import": "./dist/studio/client-component.js",
"require": "./dist/studio/client-component.cjs",
"default": "./dist/studio/client-component.js"
},
"./visual-editing/client-component": {
"source": "./src/visual-editing/client-component/index.ts",
"import": "./dist/visual-editing/client-component.js",
"require": "./dist/visual-editing/client-component.cjs",
"default": "./dist/visual-editing/client-component.js"
},
"./visual-editing/server-actions": {
"source": "./src/visual-editing/server-actions/index.ts",
"import": "./dist/visual-editing/server-actions.js",
"require": "./dist/visual-editing/server-actions.cjs",
"default": "./dist/visual-editing/server-actions.js"
},
"./webhook": {
"source": "./src/webhook/index.ts",
Expand All @@ -69,16 +87,25 @@
"typesVersions": {
"*": {
"image": [
"./dist/image/index.d.ts"
"./dist/image.d.ts"
],
"preview": [
"./dist/preview/index.d.ts"
"./dist/preview.d.ts"
],
"preview/live-query": [
"./dist/preview/live-query.d.ts"
],
"studio": [
"./dist/studio/index.d.ts"
"./dist/studio.d.ts"
],
"studio/client-component": [
"./dist/studio/client-component.d.ts"
],
"visual-editing/client-component": [
"./dist/visual-editing/client-component.d.ts"
],
"visual-editing/server-actions": [
"./dist/visual-editing/server-actions.d.ts"
],
"webhook": [
"./dist/webhook.d.ts"
Expand Down
2 changes: 1 addition & 1 deletion packages/next-sanity/src/image/Image.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import NextImage, {ImageProps as NextImageProps} from 'next/image'
import NextImage, {type ImageProps as NextImageProps} from 'next/image'

import {imageLoader} from './imageLoader'

Expand Down
2 changes: 0 additions & 2 deletions packages/next-sanity/src/image/imageLoader.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use client'

import type {ImageLoader} from 'next/image'

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
'use client'

import {memo, useMemo} from 'react'

Check warning on line 1 in packages/next-sanity/src/studio/client-component/NextStudio.tsx

View workflow job for this annotation

GitHub Actions / build

Run autofix to sort these imports!
import {Studio, type StudioProps} from 'sanity'

import {createHashHistoryForStudio} from './createHashHistoryForStudio'
import {NextStudioLayout} from './NextStudioLayout'
import {NextStudioNoScript} from './NextStudioNoScript'
import {NextStudioLayout} from '../NextStudioLayout'
import {NextStudioNoScript} from '../NextStudioNoScript'
import {StyledComponentsRegistry} from './registry'
import {useIsMounted} from './useIsMounted'

Expand Down
1 change: 1 addition & 0 deletions packages/next-sanity/src/studio/client-component/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './NextStudio'
3 changes: 2 additions & 1 deletion packages/next-sanity/src/studio/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
export {metadata, viewport} from './head'

Check warning on line 1 in packages/next-sanity/src/studio/index.ts

View workflow job for this annotation

GitHub Actions / build

Run autofix to sort these exports!
export * from './NextStudio'
export {NextStudio} from 'next-sanity/studio/client-component'
export type {NextStudioProps} from 'next-sanity/studio/client-component'
export * from './NextStudioLayout'
export * from './NextStudioNoScript'
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
'use client'

import {

Check warning on line 1 in packages/next-sanity/src/visual-editing/client-component/index.ts

View workflow job for this annotation

GitHub Actions / build

Run autofix to sort these imports!
enableVisualEditing,
type HistoryAdapterNavigate,
Expand All @@ -8,7 +6,7 @@ import {
import {usePathname, useRouter, useSearchParams} from 'next/navigation.js'
import {useEffect, useRef, useState} from 'react'

import {revalidateRootLayout} from './actions'
import {revalidateRootLayout} from 'next-sanity/visual-editing/server-actions'

/**
* @public
Expand Down
6 changes: 3 additions & 3 deletions packages/next-sanity/src/visual-editing/index.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {lazy, Suspense} from 'react'

Check warning on line 1 in packages/next-sanity/src/visual-editing/index.tsx

View workflow job for this annotation

GitHub Actions / build

Run autofix to sort these imports!

import type {VisualEditingProps} from './VisualEditing'
import type {VisualEditingProps} from 'next-sanity/visual-editing/client-component'

const VisualEditingComponent = lazy(() => import('./VisualEditing'))
const VisualEditingComponent = lazy(() => import('next-sanity/visual-editing/client-component'))

/**
* @public
Expand All @@ -15,7 +15,7 @@ export function VisualEditing(props: VisualEditingProps): React.ReactElement {
)
}

export type {VisualEditingProps} from './VisualEditing'
export type {VisualEditingProps} from 'next-sanity/visual-editing/client-component'

Check warning on line 18 in packages/next-sanity/src/visual-editing/index.tsx

View workflow job for this annotation

GitHub Actions / build

Run autofix to sort these exports!
export {
type CreateDataAttribute,
createDataAttribute,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
'use server'
/**
* The code in this file will be ported to `next-sanity`
*/
import {revalidatePath} from 'next/cache.js'
import {draftMode} from 'next/headers.js'

Expand Down
37 changes: 16 additions & 21 deletions packages/next-sanity/tsconfig.base.json
Original file line number Diff line number Diff line change
@@ -1,25 +1,20 @@
{
"extends": "@sanity/pkg-utils/tsconfig/strictest.json",
"compilerOptions": {
"baseUrl": ".",
"target": "esnext",
"lib": ["dom", "dom.iterable", "esnext"],
"allowJs": true,
"skipLibCheck": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"module": "preserve",
"moduleDetection": "force",
"isolatedModules": true,
"jsx": "preserve",
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"noImplicitThis": true,
"alwaysStrict": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true
"rootDir": ".",
"outDir": "dist",
"paths": {
"next-sanity/image": ["./src/image/index.ts"],
"next-sanity/preview/live-query": [
"./src/preview/LiveQuery/index.ts"
],
"next-sanity/preview": ["./src/preview/index.ts"],
"next-sanity/studio/client-component": ["./src/studio/client-component/index.ts"],
"next-sanity/studio": ["./src/studio/index.ts"],
"next-sanity/visual-editing/client-component": ["./src/visual-editing/client-component/index.ts"],
"next-sanity/visual-editing/server-actions": ["./src/visual-editing/server-actions/index.ts"],
"next-sanity/webhook": ["./src/webhook/index.ts"],
"next-sanity": ["./src/index"]
}
}
}
9 changes: 1 addition & 8 deletions packages/next-sanity/tsconfig.build.json
Original file line number Diff line number Diff line change
@@ -1,12 +1,5 @@
{
"extends": "./tsconfig.base",
"compilerOptions": {
"rootDir": "src",
"outDir": "dist",
"declaration": true,
"emitDeclarationOnly": true,
"declarationDir": "lib/dts"
},
"include": ["src/**/*.ts", "src/**/*.tsx"],
"exclude": ["dist", "node_modules"]
"exclude": ["dist", "node_modules", "./src/**/*.test.ts", "./src/**/*.test.tsx"]
}
9 changes: 3 additions & 6 deletions packages/next-sanity/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
{
"extends": "./tsconfig.base",
"include": ["**/*.ts", "**/*.tsx"],
"exclude": ["dist", "node_modules"],
"compilerOptions": {
"incremental": true,
"noEmit": true,
"plugins": [
{
"name": "next"
}
],
"strictNullChecks": true
},
"include": ["**/*.ts", "**/*.tsx", ".next/types/**/*.ts"],
"exclude": ["dist", "node_modules"]
}
}

0 comments on commit 2c62182

Please sign in to comment.