Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve bundler output #1358

Merged
merged 1 commit into from Apr 23, 2024
Merged

fix: improve bundler output #1358

merged 1 commit into from Apr 23, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Apr 23, 2024

By removing the need to use these rollup options:

      preserveModules: true,
      preserveModulesRoot: 'src',

@stipsan stipsan requested a review from a team as a code owner April 23, 2024 14:15
Copy link

socket-security bot commented Apr 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/groq@3.38.0 None 0 8.84 kB ricokahler
npm/history@5.3.0 environment +1 149 kB mjackson
npm/styled-components@6.1.8 environment +2 3.08 MB probablyup

🚮 Removed packages: npm/postcss@8.4.31

View full report↗︎

Copy link

socket-security bot commented Apr 23, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/esbuild@0.20.2

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/esbuild@0.20.2

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-sanity-static ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 2:22pm

@stipsan stipsan merged commit b45cb04 into main Apr 23, 2024
11 of 12 checks passed
@stipsan stipsan deleted the improve-build-output branch April 23, 2024 14:23
@ecospark ecospark bot mentioned this pull request Apr 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant