Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: moved from app directory to pages for routing #182

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Conversation

snorrees
Copy link
Contributor

Same deal as for personal-website.

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nextjs-blog-cms-sanity-v3 ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 16, 2023 at 1:10PM (UTC)

@kmelve
Copy link
Member

kmelve commented Jan 13, 2023

Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍 Should we add a mention in the README about our intentions to add back appDir when Vercel says it's stable and ready for production?

@korompaiistvan
Copy link
Contributor

All good 👍 Should we add a mention in the README about our intentions to add back appDir when Vercel says it's stable and ready for production?

I know this question is probably to the contributor team, but I've been working on a blog based on this template for the past couple weeks and I would personally appreciate such a note (and maybe some insight on which appDir issues impact this template badly enough to migrate back to pages/)

thank you for the template though, really helpful!

@snorrees
Copy link
Contributor Author

All good 👍 Should we add a mention in the README about our intentions to add back appDir when Vercel says it's stable and ready for production?

I know this question is probably to the contributor team, but I've been working on a blog based on this template for the past couple weeks and I would personally appreciate such a note (and maybe some insight on which appDir issues impact this template badly enough to migrate back to pages/)

thank you for the template though, really helpful!

Will add a note. We dont have a clear list of issues, just a general "its not ready yet" based on using it this far.

@snorrees snorrees merged commit 946c3a9 into main Jan 16, 2023
@snorrees snorrees deleted the app-to-pages branch January 16, 2023 13:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants