feat: Chokidar use polling on rollup watch #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issues where npm run watch would only register changes once on WSL/NVIM, turns out there is something called safe-write that some editors implement. Either way it could be turned off in nvim with
:set backupcopy=yes, or setting a usePolling property on the chokidar watch config, which is what rollup watch uses when available. How you want to implement this or if you want to is ofcourse up to you. Maybe detecting safe-write is possible. There is some discussion on this thread: parcel-bundler/parcel#221 (comment)