Silent Upload Failure if window.crypto.subtle Not Available
#50
Comments
robinpyon
added a commit
that referenced
this issue
Sep 12, 2022
|
Great catch, thank you for flagging this @mutewinter. A toast will now be displayed when trying to generate hashes / upload files from within insecure contexts in |
robinpyon
added a commit
that referenced
this issue
Oct 6, 2022
- fix: correctly infer filename from files containing uppercase extensions, tweak upload card layout - fix: fix minor regression with tag positioning, dont portal tooltips to prevent overflow issues - ci: add semver automation workflow - fix: catch errors when preview images fail to be generated (#88) - fix: throw an error when trying to call window.crypto from insecure contexts (#50) - fix: don't hardcode z-indices, correctly render last filter item (#57, #82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Heads-up that I got caught by this
TODO: https://github.com/robinpyon/sanity-plugin-media/blob/master/src/modules/uploads/index.ts#L198Turns out if you use a custom domain locally like
http://my-site.test:3000,window.crypto.subtleisn't defined in that environment. Instead, you have to uselocalhost:3000when using this plugin. It would be nice if there were a Toasted error message if the file hash generation fails. Or perhaps even disable upload entirely if the crypto APIs aren't available.The text was updated successfully, but these errors were encountered: