Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: single autogenerated subtitle, better GraphQL support, proper audio file previews, improved documentation #366

Merged
merged 10 commits into from
May 28, 2024
Merged

Fix: single autogenerated subtitle, better GraphQL support, proper audio file previews, improved documentation #366

merged 10 commits into from
May 28, 2024

Conversation

hdoro
Copy link
Collaborator

@hdoro hdoro commented May 20, 2024 •
edited

Besides limiting auto-generated captions to a single one, as requested by the Mux team due to Whisper's limitations in translating transcripts, this PR takes care of the following issues:

  1. Audio files render a large black placeholder #51
  2. Audio preview/browse gives errors #128
  3. put duration in better place in graphQL #43
  4. Not able to "log out" from the plugin using the Access Tokens for client usage. #326 (through documentation)
  5. Revalidate API token #334 (through documentation)
  6. Asset is sometimes empty in production build #57

It also upgrades the plugin's build step to use @sanity/plugin-kit@^4.0.0, so builds may break on Vercel. Would love your eyes on this part, @stipsan :)

@hdoro hdoro requested a review from stipsan May 20, 2024 20:47
@hdoro hdoro requested a review from a team as a code owner May 20, 2024 20:47
@vercel Vercel
Copy link

vercel bot commented May 20, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sanity-plugin-mux-input ❌ Failed (Inspect) May 28, 2024 0:56am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sanity-plugin-mux-input-codesandbox ⬜️ Ignored (Inspect) Visit Preview May 28, 2024 0:56am

@socket-security Socket Security
Copy link

socket-security bot commented May 20, 2024 •
edited

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@commitlint/cli@19.3.0 Transitive: environment, eval, filesystem, shell, unsafe +31 3.75 MB escapedcat
npm/@commitlint/config-conventional@19.2.2 Transitive: filesystem +8 2.2 MB escapedcat
npm/@mux/mux-player-react@2.6.0 Transitive: network +6 14.7 MB mux-npmjs
npm/@mux/upchunk@3.4.0 None +1 916 kB mux-npmjs
npm/@sanity/client@6.18.2 Transitive: environment, network +8 3.36 MB sanity-io
npm/@sanity/icons@2.11.8 None 0 1.27 MB sanity-io
npm/@sanity/pkg-utils@6.8.16 environment Transitive: eval, filesystem, network, shell, unsafe +124 283 MB sanity-io
npm/@sanity/plugin-kit@4.0.12 Transitive: environment, eval, filesystem, network, shell, unsafe +133 258 MB sanity-io
npm/@sanity/ui@2.1.11 Transitive: environment +9 8.6 MB sanity-io
npm/@sanity/vision@3.42.1 Transitive: environment +25 5.52 MB ricokahler
npm/@types/lodash@4.17.4 None 0 863 kB types
npm/@types/react-is@18.3.0 None 0 5.72 kB types
npm/@types/react@18.3.2 None +2 1.69 MB types
npm/@types/styled-components@5.1.34 None +2 1.28 MB types
npm/@typescript-eslint/eslint-plugin@7.10.0 Transitive: environment +12 5.83 MB jameshenry
npm/@typescript-eslint/parser@7.10.0 Transitive: environment +8 1.9 MB jameshenry
npm/eslint-config-react-app@7.0.1 Transitive: environment, eval, filesystem, unsafe +222 30.5 MB iansu
npm/eslint-plugin-react-hooks@4.6.2 environment 0 118 kB react-bot
npm/eslint-plugin-simple-import-sort@12.1.0 None 0 38.2 kB lydell

🚮 Removed packages: npm/@commitlint/cli@19.2.1, npm/@commitlint/config-conventional@19.1.0, npm/@mux/mux-player-react@2.4.1, npm/@mux/upchunk@3.3.2, npm/@sanity/client@6.15.11, npm/@sanity/icons@2.11.7, npm/@sanity/pkg-utils@6.0.1, npm/@sanity/plugin-kit@3.1.10, npm/@sanity/ui@2.1.0, npm/@sanity/vision@3.36.4, npm/@types/lodash@4.17.0, npm/@types/node@20.11.20, npm/@types/react-is@18.2.4, npm/@types/react@18.2.74, npm/@typescript-eslint/eslint-plugin@7.6.0, npm/@typescript-eslint/parser@7.6.0, npm/eslint-plugin-react-hooks@4.6.0, npm/eslint-plugin-simple-import-sort@12.0.0

View full report↗︎

stipsan
stipsan reviewed May 21, 2024
View reviewed changes
example/package.json Outdated Show resolved Hide resolved
stipsan
stipsan approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hdoro @stipsan
fix(example): use plugin's published version
2e39b98 
Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com>
Signed-off-by: henrique doro <opensource@hdoro.dev>
@stipsan stipsan merged commit e8b8757 into main May 28, 2024
13 of 15 checks passed
@stipsan stipsan deleted the fix/single-autogenerated-subtitle branch May 28, 2024 13:07
stipsan added a commit that referenced this pull request Jun 6, 2024
@hdoro @stipsan
fix: single autogenerated subtitle, better GraphQL support, proper au…
594e999 
…dio file previews, improved documentation (#366)

* chore: migrate to plugin-kit@4.0.13

* docs: note on autogenerated subtitles

* fix(useImportMuxAssets): handle assets without playbackIds

* chore: upgrade example dependencies

* fix: properly annotate schema for GraphQL

* fix: better render audio previews

* feat: only enable one auto-generated caption

* chore: update plugin version

* chore(prettier): 🤖 ✨

* fix(example): use plugin's published version

Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com>
Signed-off-by: henrique doro <opensource@hdoro.dev>

---------

Signed-off-by: henrique doro <opensource@hdoro.dev>
Co-Authored-By: hdoro <hdoro@users.noreply.github.com>
Co-Authored-By: Cody Olsen <81981+stipsan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stipsan stipsan stipsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hdoro @stipsan