[image-url] Code style fixes

sanity-io · Apr 9, 2018 · 13b75dd · 13b75dd
1 parent fa63389
commit 13b75dd
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 8 deletions.
diff --git a/packages/@sanity/image-url/.eslintignore b/packages/@sanity/image-url/.eslintignore
@@ -0,0 +1 @@
+lib/
diff --git a/packages/@sanity/image-url/index.js b/packages/@sanity/image-url/index.js
@@ -1 +1,2 @@
+// eslint-disable-next-line import/no-commonjs
 module.exports = require('./lib/builder').default
diff --git a/packages/@sanity/image-url/src/builder.js b/packages/@sanity/image-url/src/builder.js
@@ -151,7 +151,7 @@ class ImageUrlBuilder {
 
 export default function urlBuilder(options) {
   // Did we get a SanityClient?
-  if (options && typeof options.clientConfig == 'object') {
+  if (options && typeof options.clientConfig === 'object') {
     // Inherit config from client
     return new ImageUrlBuilder(null, {
       baseUrl: options.clientConfig.apiHost.replace(/^https:\/\/api\./, 'https://cdn.'),

diff --git a/packages/@sanity/image-url/src/urlForImage.js b/packages/@sanity/image-url/src/urlForImage.js
@@ -112,7 +112,7 @@ export function parseSource(source) {
 function parseAssetId(ref) {
   const [, id, dimensionString, format] = ref.split('-')
 
-  if (!(typeof dimensionString == 'string')) {
+  if (!(typeof dimensionString === 'string')) {
     throw new Error(
       `Malformed asset _ref '${ref}'. Expected an id on the form "image-Tb9Ew8CXIwaY6R1kjMvI0uRR-2000x3000-jpg.`
     )
@@ -125,8 +125,8 @@ function parseAssetId(ref) {
 
   if (
     !(
-      typeof id == 'string' &&
-      typeof format == 'string' &&
+      typeof id === 'string' &&
+      typeof format === 'string' &&
       Number.isFinite(width) &&
       Number.isFinite(height)
     )
@@ -139,7 +139,7 @@ function parseAssetId(ref) {
   return {id, width, height, format}
 }
 
-/* eslint-disable complexity */
+// eslint-disable-next-line complexity
 function specToImageUrl(spec) {
   const cdnUrl = spec.baseUrl || 'https://cdn.sanity.io'
   const filename = `${spec.asset.id}-${spec.asset.width}x${spec.asset.height}.${spec.asset.format}`
@@ -176,7 +176,7 @@ function specToImageUrl(spec) {
     }
   })
 
-  if (params.length == 0) {
+  if (params.length === 0) {
     return baseUrl
   }
 

diff --git a/packages/@sanity/image-url/test/builder.test.js b/packages/@sanity/image-url/test/builder.test.js
@@ -1,5 +1,5 @@
-import sanityImage from '../src/builder'
 import should from 'should'
+import sanityImage from '../src/builder'
 import {imageWithNoCropSpecified, croppedImage} from './fixtures'
 
 const urlFor = sanityImage()

diff --git a/packages/@sanity/image-url/test/parseSource.test.js b/packages/@sanity/image-url/test/parseSource.test.js
@@ -9,19 +9,22 @@ function compareParsedSource(outputSource, exptectedSource) {
   should(outputSource).have.keys('crop', 'hotspot')
 }
 
-describe('[image-url] parseSource', () => {
+describe('parseSource', () => {
   it('does correctly parse full image object', () => {
     const parsedSource = parseSource(imageWithNoCropSpecified())
     compareParsedSource(parsedSource, imageWithNoCropSpecified())
   })
+
   it('does correctly parse asset object', () => {
     const parsedSource = parseSource(imageWithNoCropSpecified().asset._ref)
     compareParsedSource(parsedSource, imageWithNoCropSpecified())
   })
+
   it('does correctly parse image asset _ref', () => {
     const parsedSource = parseSource(imageWithNoCropSpecified().asset)
     compareParsedSource(parsedSource, imageWithNoCropSpecified())
   })
+
   it('does not overwrite cropp or hotspot settings', () => {
     should(parseSource(croppedImage())).deepEqual(croppedImage())
   })

diff --git a/packages/@sanity/image-url/urlForImage.js b/packages/@sanity/image-url/urlForImage.js
@@ -1 +1,2 @@
+// eslint-disable-next-line import/no-commonjs
 module.exports = require('./lib/urlForImage').default