Skip to content

Commit

Permalink
chore: apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com>
  • Loading branch information
2 people authored and rexxars committed Feb 14, 2024
1 parent 70bcf6f commit 1b7a1f1
Show file tree
Hide file tree
Showing 16 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cli-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Build CLI
run: pnpm build # Needed for CLI tests
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/depCheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Check for unused/missing dependencies
id: depcheck
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docReport.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Build packages
run: pnpm build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-ct.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Store Playwright's Version
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e-pte.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Store Playwright's Version
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Store Playwright's Version
run: |
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Store Playwright's Version
run: |
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Download blob reports from Github Actions Artifacts
uses: actions/download-artifact@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/etl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Build packages
run: pnpm build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/formatCheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Run format check
run: pnpm turbo run check:format
4 changes: 2 additions & 2 deletions .github/workflows/lint-fix-if-needed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
${{ runner.os }}-
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install
- name: Cache ESLint cache
uses: actions/cache@v3
with:
Expand All @@ -60,7 +60,7 @@ jobs:
# Run even if `lint:fix` fails
if: always()
with:
body: "I ran `lint:fix --rule 'prettier/prettier: [off]'` 🧑‍💻"
body: "I ran `pnpm lint:fix --rule 'prettier/prettier: [off]'` 🧑‍💻"
branch: actions/lint-fix-if-needed
commit-message: 'chore(lint): fix linter issues 🤖 ✨'
labels: 🤖 bot
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lintPr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Lint files
run: pnpm lint
2 changes: 1 addition & 1 deletion .github/workflows/perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
working-directory: ./perf
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Store Playwright's Version
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pnpm-if-needed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ jobs:
${{ runner.os }}-
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --ignore-scripts --frozen-lockfile --force
- run: pnpm dedupe
run: pnpm install --config.ignore-scripts=true
- run: pnpm dedupe --config.ignore-scripts=true
- uses: tibdex/github-app-token@3beb63f4bd073e61482598c45c71c1019b59b73a # v2
id: generate-token
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-cleanup.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Remove docs report datasets for closed PRs
env:
Expand Down Expand Up @@ -74,7 +74,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Remove E2E datasets for closed PRs
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/prettier-if-needed.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
${{ runner.os }}-
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --ignore-scripts --frozen-lockfile
run: pnpm install --config.ignore-scripts=true
- name: Cache Prettier
uses: actions/cache@v3
with:
Expand All @@ -58,7 +58,7 @@ jobs:
private_key: ${{ secrets.ECOSPARK_APP_PRIVATE_KEY }}
- uses: peter-evans/create-pull-request@b1ddad2c994a25fbc81a28b3ec0e368bb2021c50 # v6
with:
body: I ran `prettier` 🧑‍💻
body: I ran `pnpm prettier` 🧑‍💻
branch: actions/prettier-if-needed
commit-message: 'chore(prettier): fix unformatted files 🤖 ✨'
labels: 🤖 bot
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:

- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Build CLI
run: pnpm build # Needed for CLI tests
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:

- name: Install project dependencies
if: steps.restore-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Test
id: test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/typeCheck.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Install project dependencies
if: steps.cache-node-modules.outputs.cache-hit != 'true'
run: pnpm install --frozen-lockfile
run: pnpm install

- name: Check type system
# If TypeScript project references is set up properly, `tsc --build` should work right after dependencies
Expand Down

0 comments on commit 1b7a1f1

Please sign in to comment.