Skip to content

Commit

Permalink
refactor(sanity): move changeIndicators out of components
Browse files Browse the repository at this point in the history
  • Loading branch information
mariuslundgard committed Oct 4, 2022
1 parent ec5b530 commit 1e17d76
Show file tree
Hide file tree
Showing 44 changed files with 33 additions and 29 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React, {memo} from 'react'
import deepCompare from 'react-fast-compare'
import * as PathUtils from '@sanity/util/paths'
import {Path} from '@sanity/types'
import {EMPTY_ARRAY} from '../../util'
import {EMPTY_ARRAY} from '../util'
import {useReporter} from './tracker'
import {ElementWithChangeBar} from './ElementWithChangeBar'

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {Reported} from '../../react-track-elements'
import {Reported} from '../../components/react-track-elements'
import {TrackedArea, TrackedChange} from '../tracker'

export function isChangeBar(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, {useMemo} from 'react'
import {Path} from '@sanity/types'
import {ScrollContainer} from '../../scroll'
import {ScrollContainer} from '../../components/scroll'
import {ConnectorContext} from '../ConnectorContext'
import {ENABLED} from '../constants'
import {Tracker} from '../tracker'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
import React, {useCallback, useMemo, useState} from 'react'
import {sortBy} from 'lodash'
import {Path} from '@sanity/types'
import {ScrollMonitor} from '../../scroll'
import {ScrollMonitor} from '../../components/scroll'
import {findMostSpecificTarget} from '../helpers/findMostSpecificTarget'
import {isChangeBar} from '../helpers/isChangeBar'
import {scrollIntoView} from '../helpers/scrollIntoView'
import {DEBUG_LAYER_BOUNDS} from '../constants'
import {getOffsetsTo} from '../helpers/getOffsetsTo'
import {TrackedArea, TrackedChange, useReportedValues} from '../tracker'
import {Reported} from '../../react-track-elements'
import {isNonNullable} from '../../../util'
import {Reported} from '../../components/react-track-elements'
import {isNonNullable} from '../../util'
import {Connector} from './Connector'
import {DebugLayers} from './DebugLayers'
import {useResizeObserver} from './useResizeObserver'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {useEffect} from 'react'
import {resizeObserver} from '../../../util'
import {resizeObserver} from '../../util'

export function useResizeObserver(
element: HTMLDivElement,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {Path} from '@sanity/types'
import {createNoopTrackerScope, createTrackerScope} from '../react-track-elements'
import {createNoopTrackerScope, createTrackerScope} from '../components/react-track-elements'
import {ENABLED} from './constants'

/** @internal */
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {Container, Flex, TextArea} from '@sanity/ui'
import {useBoolean} from '@sanity/ui-workshop'
import React, {useCallback, useState} from 'react'
import {ElementWithChangeBar} from '../changeIndicators/ElementWithChangeBar'
import {ElementWithChangeBar} from '../../changeIndicators/ElementWithChangeBar'

export default function ChangeBarStory() {
const isChanged = useBoolean('Changed', true, 'Props')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import {Card, Container, Flex, LayerProvider, Stack, Text} from '@sanity/ui'
import React, {useCallback, useState} from 'react'
import styled from 'styled-components'
import {ScrollContainer} from '../scroll'
import {ChangeFieldWrapper} from '../changeIndicators/ChangeFieldWrapper'
import {ChangeIndicator} from '../changeIndicators/ChangeIndicator'
import {ChangeConnectorRoot} from '../changeIndicators/overlay/ChangeConnectorRoot'
import {ChangeFieldWrapper} from '../../changeIndicators/ChangeFieldWrapper'
import {ChangeIndicator} from '../../changeIndicators/ChangeIndicator'
import {ChangeConnectorRoot} from '../../changeIndicators/overlay/ChangeConnectorRoot'

const TestContainer = styled(Container).attrs({
height: 'fill',
Expand Down
1 change: 0 additions & 1 deletion packages/sanity/src/core/components/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ export * from './PreviewCard'
export * from './TextWithTone'
export * from './UserAvatar'
export * from './WithReferringDocuments'
export * from './changeIndicators'
export * from './collapseMenu'
export * from './globalErrorHandler'
export * from './hookCollection'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {ChangeList, DiffContext, DiffTooltip, useDiffAnnotationColor} from '../.
import {ObjectDiff} from '../../../../types'
import {PortableTextChild} from '../types'
import {isEmptyObject} from '../helpers'
import {ConnectorContext, useReportedValues} from '../../../../../components'
import {ConnectorContext, useReportedValues} from '../../../../../changeIndicators'
import {InlineBox, InlineText, PopoverContainer, PreviewContainer} from './styledComponents'

interface AnnotationProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import React, {useCallback, useContext} from 'react'
import {DiffContext, DiffTooltip, useDiffAnnotationColor} from '../../../../diff'
import {isHeader} from '../helpers'
import {PortableTextBlock, PortableTextDiff} from '../types'
import {ConnectorContext} from '../../../../../components'
import {ConnectorContext} from '../../../../../changeIndicators'
import Blockquote from './Blockquote'
import Header from './Header'
import Paragraph from './Paragraph'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {ObjectDiff} from '../../../../types'
import {PortableTextChild} from '../types'
import {isEmptyObject} from '../helpers'
import {SanityPreview} from '../../../../../preview'
import {ConnectorContext, useReportedValues} from '../../../../../components'
import {ConnectorContext, useReportedValues} from '../../../../../changeIndicators'
import {InlineBox, InlineText, PopoverContainer, PreviewContainer} from './styledComponents'

interface InlineObjectProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import React, {SyntheticEvent, useCallback, useMemo} from 'react'
import {startCase} from 'lodash'
import {DiffCard, DiffContext} from '../../../../diff'
import {ObjectDiff, StringDiff, StringDiffSegment} from '../../../../types'
import {ConnectorContext} from '../../../../../components'
import {ConnectorContext} from '../../../../../changeIndicators'
import {InlineBox} from './styledComponents'

interface TextProps {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ import {AlertStrip} from '../../components/AlertStrip'
import {useOnClickOutside} from '../../hooks/useOnClickOutside'
import {getPublishedId, isNonNullable} from '../../../util'
import {FIXME} from '../../../FIXME'
import {ChangeIndicator, PreviewCard} from '../../../components'
import {PreviewCard} from '../../../components'
import {ChangeIndicator} from '../../../changeIndicators'
import {CrossDatasetReferenceInfo, CrossDatasetSearchHit, SearchState} from './types'
import {OptionPreview} from './OptionPreview'
import {GetReferenceInfoFn, useReferenceInfo} from './useReferenceInfo'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {FormInput} from '../../components'
import {ActivateOnFocus} from '../../components/ActivateOnFocus/ActivateOnFocus'
import {EMPTY_ARRAY} from '../../../util'
import {FIXME} from '../../../FIXME'
import {ChangeIndicator} from '../../../components'
import {ChangeIndicator} from '../../../changeIndicators'
import {BlockObject} from './object/BlockObject'
import {InlineObject} from './object/InlineObject'
import {Annotation, TextBlock} from './text'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import styled, {css} from 'styled-components'
import {ChangeIndicator} from '../../../../components'
import {ChangeIndicator} from '../../../../changeIndicators'

export const StyledChangeIndicatorWithProvidedFullPath = styled(ChangeIndicator)(() => {
return css`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ import {set, setIfMissing, unset} from '../../patch'
import {AlertStrip} from '../../components/AlertStrip'
import {Alert} from '../../components/Alert'
import {useOnClickOutside} from '../../hooks/useOnClickOutside'
import {ChangeIndicator, PreviewCard} from '../../../components'
import {ChangeIndicator} from '../../../changeIndicators'
import {PreviewCard} from '../../../components'
import {EMPTY_ARRAY, getPublishedId, isNonNullable} from '../../../util'
import {FIXME} from '../../../FIXME'
import {ReferenceInputProps, CreateReferenceOption, ReferenceSearchState} from './types'
Expand Down
2 changes: 1 addition & 1 deletion packages/sanity/src/core/form/inputs/SelectInput.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {isTitledListValue, TitledListValue} from '@sanity/types'
import {Box, Card, Flex, Inline, Radio, Select, Stack, Text} from '@sanity/ui'
import {capitalize} from 'lodash'
import React, {forwardRef, useCallback, useMemo} from 'react'
import {ChangeIndicator} from '../../components'
import {ChangeIndicator} from '../../changeIndicators'
import {PatchEvent, set, unset} from '../patch'
import {StringInputProps} from '../types'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import {isReferenceSchemaType, Path, SchemaType} from '@sanity/types'
import {Box} from '@sanity/ui'
import React, {memo, useCallback, useRef} from 'react'
import {ChangeIndicator} from '../../../../../components'
import {ChangeIndicator} from '../../../../../changeIndicators'
import {ArrayInputMember} from '../types'
import {useScrollIntoViewOnFocusWithin} from '../../../../hooks/useScrollIntoViewOnFocusWithin'
import {useDidUpdate} from '../../../../hooks/useDidUpdate'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ import {UploadWarning} from '../common/UploadWarning'
import {InputProps, ObjectInputProps} from '../../../types'
import {PatchEvent, setIfMissing, unset} from '../../../patch'
import {MemberField, MemberFieldError, MemberFieldSet} from '../../../members'
import {ChangeIndicator, ImperativeToast} from '../../../../components'
import {ImperativeToast} from '../../../../components'
import {ChangeIndicator} from '../../../../changeIndicators'
import {FIXME} from '../../../../FIXME'
import {CardOverlay, FlexContainer} from './styles'
import {FileDetails} from './FileDetails'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ import {FormInput} from '../../../components'
import {MemberField, MemberFieldError, MemberFieldSet} from '../../../members'
import {PresenceOverlay} from '../../../../presence'
import {FIXME} from '../../../../FIXME'
import {ChangeIndicator, ImperativeToast} from '../../../../components'
import {ImperativeToast} from '../../../../components'
import {ChangeIndicator} from '../../../../changeIndicators'
import {ImageActionsMenu} from './ImageActionsMenu'
import {ImagePreview} from './ImagePreview'
import {InvalidImageWarning} from './InvalidImageWarning'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {set} from '../../../patch'
import {RatioBox} from '../common/RatioBox'
import type {ObjectInputProps} from '../../../types'
import {useDidUpdate} from '../../../hooks/useDidUpdate'
import {ChangeIndicator} from '../../../../components'
import {ChangeIndicator} from '../../../../changeIndicators'
import {EMPTY_ARRAY} from '../../../../util'
import {ImageTool, HotspotImage, DEFAULT_CROP, DEFAULT_HOTSPOT} from './imagetool'
import {useLoadImage} from './useLoadImage'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ import {FieldMember} from '../../store'
import {ArrayFieldProps, FieldProps, InputProps, ItemProps, ObjectFieldProps} from '../../types'
import * as is from '../../utils/is'
import {FormField, FormFieldSet} from '../../components/formField'
import {ChangeIndicator, PreviewProps} from '../../../components'
import {PreviewProps} from '../../../components'
import {ChangeIndicator} from '../../../changeIndicators'
import {SanityPreview} from '../../../preview'
import {FIXME} from '../../../FIXME'
import {resolveReferenceInput} from './resolveReferenceInput'
Expand Down
2 changes: 1 addition & 1 deletion packages/sanity/src/core/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export * from './components/PreviewCard'
export * from './components/TextWithTone'
export * from './components/UserAvatar'
export * from './components/WithReferringDocuments'
export * from './components/changeIndicators'
export * from './changeIndicators'
export * from './components/collapseMenu'
export * from './components/globalErrorHandler'
export * from './components/hookCollection'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {format} from 'date-fns'
import {omit} from 'lodash'
import React, {useCallback, useEffect, useMemo, useState} from 'react'
import {useMemoObservable} from 'react-rx'
import {ChangeFieldWrapper} from '../../../components'
import {ChangeFieldWrapper} from '../../../changeIndicators'
import {
ChangeList,
DocumentChangeContext,
Expand Down

0 comments on commit 1e17d76

Please sign in to comment.