refactor(portable-text-editor): change plugin callstack

The order was called in the reverse order of the order intended
sanity-io · Mar 24, 2022 · 304964b · 304964b · vercel · Mar 24, 2022
1 parent a4941ea
commit 304964b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/packages/@sanity/portable-text-editor/src/editor/Editable.tsx b/packages/@sanity/portable-text-editor/src/editor/Editable.tsx
@@ -157,7 +157,7 @@ export const PortableTextEditable = forwardRef(function PortableTextEditable(
   )
 
   // Update the Slate instance's plugins which are dependent on props for Editable
-  useMemo(() => withHotKeys(withInsertData(withEditableAPI(withReact(slateEditor)))), [
+  useMemo(() => withReact(withEditableAPI(withInsertData(withHotKeys(slateEditor)))), [
     slateEditor,
     withEditableAPI,
     withHotKeys,

diff --git a/packages/@sanity/portable-text-editor/src/editor/withPortableText.ts b/packages/@sanity/portable-text-editor/src/editor/withPortableText.ts
@@ -61,16 +61,12 @@ export const withPortableText = <T extends Editor>(
   const withPortableTextSelections = createWithPortableTextSelections(change$)
 
   // Ordering is important here, selection dealing last, data manipulation in the middle and core model stuff first.
-  return withPortableTextSelections(
-    withPatches(
-      withUndoRedo(
-        withMaxBlocks(
-          withUtils(
-            withPortableTextLists(
-              withPortableTextBlockStyle(
-                withPortableTextMarkModel(withObjectKeys(withSchemaTypes(e)))
-              )
-            )
+  return withSchemaTypes(
+    withObjectKeys(
+      withPortableTextMarkModel(
+        withPortableTextBlockStyle(
+          withPortableTextLists(
+            withUtils(withMaxBlocks(withUndoRedo(withPatches(withPortableTextSelections(e)))))
           )
         )
       )