[components] Require setOpen property for MenuButton

sanity-io · Oct 6, 2020 · 430f4f9 · 430f4f9
1 parent 1c327fe
commit 430f4f9
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/packages/@sanity/components/src/menuButton/menuButton.tsx b/packages/@sanity/components/src/menuButton/menuButton.tsx
@@ -11,7 +11,7 @@ interface MenuButtonProps {
   menu?: React.ReactNode
   placement?: string
   open?: boolean
-  setOpen?: (val: boolean) => void
+  setOpen: (val: boolean) => void
 }
 
 export function MenuButton(props: MenuButtonProps & React.HTMLProps<HTMLDivElement>) {
@@ -26,15 +26,8 @@ export function MenuButton(props: MenuButtonProps & React.HTMLProps<HTMLDivEleme
     ...restProps
   } = props
 
-  const handleClickOutside = useCallback(() => {
-    if (!setOpen) return
-    setOpen(false)
-  }, [setOpen])
-
-  const handleButtonClick = useCallback(() => {
-    if (!setOpen) return
-    setOpen(!open)
-  }, [open, setOpen])
+  const handleClickOutside = useCallback(() => setOpen(false), [setOpen])
+  const handleButtonClick = useCallback(() => setOpen(!open), [open, setOpen])
 
   return (
     <ClickOutside onClickOutside={handleClickOutside}>