[desk-tool] Enable review changes for liveEdit documents

sanity-io · Oct 6, 2020 · 80c1c67 · 80c1c67
1 parent f30c8f7
commit 80c1c67
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 27 deletions.
diff --git a/packages/@sanity/desk-tool/src/panes/documentPane/documentPanel/documentPanel.tsx b/packages/@sanity/desk-tool/src/panes/documentPane/documentPanel/documentPanel.tsx
@@ -59,16 +59,13 @@ export function DocumentPanel(props: DocumentPanelProps) {
   const menuItems = useMemo(() => {
     return (
       getMenuItems({
-        canShowHistoryList: true,
         features,
-        isHistoryEnabled: true,
         isHistoryOpen: props.isHistoryOpen,
-        isLiveEditEnabled: props.schemaType.liveEdit === true,
         rev: revTime ? revTime.id : null,
         value: props.value
       }) || []
     )
-  }, [props.isHistoryOpen, props.schemaType, revTime, props.value])
+  }, [features, props.isHistoryOpen, revTime, props.value])
 
   const handleContextMenuAction = useCallback(
     item => {

diff --git a/packages/@sanity/desk-tool/src/panes/documentPane/documentPanel/menuItems/menuItems.tsx b/packages/@sanity/desk-tool/src/panes/documentPane/documentPanel/menuItems/menuItems.tsx
@@ -11,39 +11,23 @@ import {Doc} from '../../types'
 import styles from './menuItems.css'
 
 interface Params {
-  canShowHistoryList?: boolean
   features: DeskToolFeatures
   isHistoryOpen?: boolean
-  isHistoryEnabled?: boolean
-  isLiveEditEnabled?: boolean
   rev: string | null
   value: Doc | null
 }
 
 const getHistoryMenuItem = (params: Params): MenuItemType | null => {
-  const {
-    features,
-    value,
-    isLiveEditEnabled,
-    isHistoryEnabled,
-    isHistoryOpen,
-    canShowHistoryList
-  } = params
+  const {features, value, isHistoryOpen} = params
 
-  if (isLiveEditEnabled || !canShowHistoryList) {
-    return null
-  }
+  if (!features.reviewChanges) return null
 
-  if (isHistoryEnabled) {
-    return {
-      action: 'reviewChanges',
-      title: 'Review changes',
-      icon: HistoryIcon,
-      isDisabled: !features.reviewChanges || isHistoryOpen || !value
-    }
+  return {
+    action: 'reviewChanges',
+    title: 'Review changes',
+    icon: HistoryIcon,
+    isDisabled: isHistoryOpen || !value
   }
-
-  return null
 }
 
 const getInspectItem = ({value}: Params): MenuItemType => ({