Skip to content

Commit

Permalink
[desk-tool] Fix hooks issues
Browse files Browse the repository at this point in the history
  • Loading branch information
mariuslundgard authored and rexxars committed Oct 6, 2020
1 parent acc28f4 commit ee47334
Showing 1 changed file with 15 additions and 19 deletions.
34 changes: 15 additions & 19 deletions packages/@sanity/desk-tool/src/panes/documentPane/documentPane.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,18 @@ export function DocumentPane(props: DocumentPaneProps) {
: []
const isInspectOpen = paneRouter.params.inspect === 'on'

const toggleInspect = useCallback(
(toggle = !isInspectOpen) => {
const {inspect: oldInspect, ...params} = paneRouter.params
if (toggle) {
paneRouter.setParams({inspect: 'on', ...params})
} else {
paneRouter.setParams(params)
}
},
[isInspectOpen, paneRouter]
)

const handleKeyUp = useCallback(
(event: any) => {
if (event.key === 'Escape' && showValidationTooltip) {
Expand All @@ -102,34 +114,18 @@ export function DocumentPane(props: DocumentPaneProps) {
}
}
},
[features]
)

const toggleInspect = useCallback(
(toggle = !isInspectOpen) => {
const {inspect: oldInspect, ...params} = paneRouter.params
if (toggle) {
paneRouter.setParams({inspect: 'on', ...params})
} else {
paneRouter.setParams(params)
}
},
[paneRouter]
[features, showValidationTooltip, toggleInspect, value]
)

const handleInspectClose = useCallback(() => {
toggleInspect(false)
}, [toggleInspect])
const handleInspectClose = useCallback(() => toggleInspect(false), [toggleInspect])

const handleSetActiveView = useCallback((id: string | null) => paneRouter.setView(id as any), [
paneRouter
])

const handleClosePane = useCallback(() => paneRouter.closeCurrent(), [paneRouter])

const handleSplitPane = useCallback(() => {
paneRouter.duplicateCurrent()
}, [paneRouter])
const handleSplitPane = useCallback(() => paneRouter.duplicateCurrent(), [paneRouter])

const changesSinceSelectRef = useRef<HTMLDivElement | null>(null)
const versionSelectRef = useRef<HTMLDivElement | null>(null)
Expand Down

0 comments on commit ee47334

Please sign in to comment.