[components] Make duplicate types of Snackbars to be disabled by default

sanity-io · May 19, 2020 · f58525a · f58525a
1 parent c756e0f
commit f58525a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/packages/@sanity/base/src/components/DevServerStatus.js b/packages/@sanity/base/src/components/DevServerStatus.js
@@ -86,6 +86,7 @@ class DevServerStatus extends PureComponent {
           title={<strong>Reload required!</strong>}
           subtitle={<div>To see your latest changes, you need to reload the browser window.</div>}
           action={{title: 'Reload', callback: () => window.location.reload()}}
+          allowDuplicateSnackbarType
         />
       )
     }
@@ -104,6 +105,7 @@ class DevServerStatus extends PureComponent {
               </div>
             </Spinner>
           }
+          allowDuplicateSnackbarType
         />
       )
     }
@@ -135,6 +137,7 @@ class DevServerStatus extends PureComponent {
               project folder.
             </div>
           }
+          allowDuplicateSnackbarType
         />
       )
     }

diff --git a/packages/@sanity/components/src/snackbar/DefaultSnackbar.js b/packages/@sanity/components/src/snackbar/DefaultSnackbar.js
@@ -19,7 +19,7 @@ export default class DefaultSnackbar extends React.PureComponent {
     onAction: PropTypes.func,
     actionTitle: PropTypes.string,
     timeout: PropTypes.number,
-    preventDuplicate: PropTypes.bool
+    allowDuplicateSnackbarType: PropTypes.bool
   }
 
   static contextTypes = {
@@ -45,7 +45,7 @@ export default class DefaultSnackbar extends React.PureComponent {
       onAction,
       isPersisted,
       isCloseable,
-      preventDuplicate
+      allowDuplicateSnackbarType
     } = this.props
 
     return {
@@ -61,7 +61,7 @@ export default class DefaultSnackbar extends React.PureComponent {
       isPersisted,
       isCloseable,
       autoDismissTimeout: timeout,
-      preventDuplicate
+      allowDuplicateSnackbarType
     }
   }
 

diff --git a/packages/@sanity/components/src/snackbar/SnackbarProvider.js b/packages/@sanity/components/src/snackbar/SnackbarProvider.js
@@ -63,7 +63,7 @@ export default class SnackbarProvider extends React.Component {
       ...contextSnack
     }
 
-    if (newSnack.preventDuplicate) {
+    if (!newSnack.allowDuplicateSnackbarType) {
       const isInQueue = this.snackQueue.findIndex(snack => snack.kind === newSnack.kind) > -1
       const isInActive = activeSnacks.findIndex(snack => snack.kind === newSnack.kind) > -1
 

diff --git a/packages/@sanity/desk-tool/src/panes/documentPane/DocumentOperationResults.tsx b/packages/@sanity/desk-tool/src/panes/documentPane/DocumentOperationResults.tsx
@@ -56,13 +56,12 @@ export const DocumentOperationResults = React.memo((props: Props) => {
             {event.error.message}
           </details>
         }
-        preventDuplicate
       />
     )
   }
 
   if (event && event.type === 'success' && !IGNORE_OPS.includes(event.op)) {
-    return <Snackbar key={Math.random()} kind="success" title={getOpSuccessTitle(event.op)} preventDuplicate />
+    return <Snackbar key={Math.random()} kind="success" title={getOpSuccessTitle(event.op)} />
   }
 
   return null